lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZejJ7W_yUMBtqi70@codewreck.org>
Date: Thu, 7 Mar 2024 04:54:21 +0900
From: Dominique Martinet <asmadeus@...ewreck.org>
To: Andrzej Pietrasiewicz <andrzej.p@...labora.com>
Cc: Michael Grzeschik <m.grzeschik@...gutronix.de>,
	Eric Van Hensbergen <ericvh@...nel.org>,
	Latchesar Ionkov <lucho@...kov.net>,
	Christian Schoenebeck <linux_oss@...debyte.com>,
	Jonathan Corbet <corbet@....net>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	v9fs@...ts.linux.dev, linux-doc@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org,
	kernel@...gutronix.de
Subject: Re: [PATCH v3 2/3] net/9p/usbg: Add new usb gadget function transport

Andrzej Pietrasiewicz wrote on Wed, Mar 06, 2024 at 04:18:54PM +0100:
> Reading the earlier discussions on v1 and v2 I was somehow under the impression
> that what you submitted here does not contain configfs support.
> 
> But once I started reading the code I realized it does.
> 
> It worked for me, both as a legacy gadget and when composed with configfs.
> 
> I noticed that when you stop the forwarder at the host side when 9pfs remains
> mounted at the gadget side, umount hangs at the gadget side until the forwarder
> is restarted. I know that once the host-side software dies, not much can be
> done, however, unmounting a dead filesystem seems a reasonable thing to do
> and the way usb9pfs worked for me it is not possible to unmount in this
> situation. Any ideas on improving this?

If the trans_usbg code can detect the host device is gone it should mark
client->status as Disconnected then wake up all pending requests
(something like p9_conn_cancel in trans_fd.c)

Sorry I haven't found time to test/review either; I'd still be
interested in running this in qemu for non-reg over using a real device
so need to spend a few minutes figuring out the exact command line
required.. I'll try to find some time this weekend

-- 
Dominique

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ