linux-kernel - Re: [PATCH v2 1/3] arch: consolidate existing CONFIG_PAGE_SIZE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87sf13nd2p.fsf@mail.lhotse>
Date: Thu, 07 Mar 2024 10:41:02 +1100
From: Michael Ellerman <mpe@...erman.id.au>
To: Arnd Bergmann <arnd@...nel.org>, Anna-Maria Behnsen
 <anna-maria@...utronix.de>, Thomas Gleixner <tglx@...utronix.de>, Vincenzo
 Frascino <vincenzo.frascino@....com>, Kees Cook <keescook@...omium.org>
Cc: Arnd Bergmann <arnd@...db.de>, Matt Turner <mattst88@...il.com>, Vineet
 Gupta <vgupta@...nel.org>, Russell King <linux@...linux.org.uk>, Catalin
 Marinas <catalin.marinas@....com>, Guo Ren <guoren@...nel.org>, Brian Cain
 <bcain@...cinc.com>, Huacai Chen <chenhuacai@...nel.org>, Geert
 Uytterhoeven <geert@...ux-m68k.org>, Michal Simek <monstr@...str.eu>,
 Thomas Bogendoerfer <tsbogend@...ha.franken.de>, Helge Deller
 <deller@....de>, Christophe Leroy <christophe.leroy@...roup.eu>, Palmer
 Dabbelt <palmer@...belt.com>, John Paul Adrian Glaubitz
 <glaubitz@...sik.fu-berlin.de>, Andreas Larsson <andreas@...sler.com>,
 Richard Weinberger <richard@....at>, x86@...nel.org, Max Filippov
 <jcmvbkbc@...il.com>, Andy Lutomirski <luto@...nel.org>, Jan Kiszka
 <jan.kiszka@...mens.com>, Kieran Bingham <kbingham@...nel.org>, Andrew
 Morton <akpm@...ux-foundation.org>, linux-kernel@...r.kernel.org,
 linux-alpha@...r.kernel.org, linux-snps-arc@...ts.infradead.org,
 linux-arm-kernel@...ts.infradead.org, linux-csky@...r.kernel.org,
 linux-hexagon@...r.kernel.org, loongarch@...ts.linux.dev,
 linux-m68k@...ts.linux-m68k.org, linux-mips@...r.kernel.org,
 linux-openrisc@...r.kernel.org, linux-parisc@...r.kernel.org,
 linuxppc-dev@...ts.ozlabs.org, linux-riscv@...ts.infradead.org,
 linux-s390@...r.kernel.org, linux-sh@...r.kernel.org,
 sparclinux@...r.kernel.org, linux-um@...ts.infradead.org
Subject: Re: [PATCH v2 1/3] arch: consolidate existing CONFIG_PAGE_SIZE_*KB
 definitions

Hi Arnd,

Arnd Bergmann <arnd@...nel.org> writes:
> From: Arnd Bergmann <arnd@...db.de>
>
> These four architectures define the same Kconfig symbols for configuring
> the page size. Move the logic into a common place where it can be shared
> with all other architectures.
>
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
> Changes from v1:
>  - improve Kconfig help texts
>  - fix Hexagon Kconfig
>
>  arch/Kconfig                      | 92 ++++++++++++++++++++++++++++++-
>  arch/hexagon/Kconfig              | 24 ++------
>  arch/hexagon/include/asm/page.h   |  6 +-
>  arch/loongarch/Kconfig            | 21 ++-----
>  arch/loongarch/include/asm/page.h | 10 +---
>  arch/mips/Kconfig                 | 58 ++-----------------
>  arch/mips/include/asm/page.h      | 16 +-----
>  arch/sh/include/asm/page.h        | 13 +----
>  arch/sh/mm/Kconfig                | 42 ++++----------
>  9 files changed, 121 insertions(+), 161 deletions(-)

There's a few "help" lines missing, which breaks the build:

  arch/Kconfig:1134: syntax error
  arch/Kconfig:1133: invalid statement
  arch/Kconfig:1134: invalid statement
  arch/Kconfig:1135:warning: ignoring unsupported character '.'
  arch/Kconfig:1135:warning: ignoring unsupported character '.'
  arch/Kconfig:1135: invalid statement
  arch/Kconfig:1136: invalid statement
  arch/Kconfig:1137:warning: ignoring unsupported character '.'
  arch/Kconfig:1137: invalid statement
  arch/Kconfig:1143: syntax error
  arch/Kconfig:1142: invalid statement
  arch/Kconfig:1143: invalid statement
  arch/Kconfig:1144:warning: ignoring unsupported character '.'
  arch/Kconfig:1144: invalid statement
  arch/Kconfig:1145: invalid statement
  arch/Kconfig:1146: invalid statement
  arch/Kconfig:1147: invalid statement
  arch/Kconfig:1148:warning: ignoring unsupported character '.'
  arch/Kconfig:1148: invalid statement
  make[4]: *** [../scripts/kconfig/Makefile:85: syncconfig] Error 1

Fixup diff is:

diff --git a/arch/Kconfig b/arch/Kconfig
index 56d45a75f625..f2295fa3b48c 100644
--- a/arch/Kconfig
+++ b/arch/Kconfig
@@ -1130,6 +1130,7 @@ config PAGE_SIZE_16KB
 config PAGE_SIZE_32KB
        bool "32KiB pages"
        depends on HAVE_PAGE_SIZE_32KB
+       help
          Using 32KiB page size will result in slightly higher performance
          kernel at the price of higher memory consumption compared to
          16KiB pages.  This option is available only on cnMIPS cores.
@@ -1139,6 +1140,7 @@ config PAGE_SIZE_32KB
 config PAGE_SIZE_64KB
        bool "64KiB pages"
        depends on HAVE_PAGE_SIZE_64KB
+       help
          Using 64KiB page size will result in slightly higher performance
          kernel at the price of much higher memory consumption compared to
          4KiB or 16KiB pages.


cheers