linux-kernel - Re: [PATCH] nilfs2: Use div64_ul() instead of do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKFNMo=324Wq9NHPKNXf07w9tpGrE8bp=Rf-AiHqnM7VqbTZPg@mail.gmail.com>
Date: Wed, 6 Mar 2024 23:45:48 +0900
From: Ryusuke Konishi <konishi.ryusuke@...il.com>
To: Thorsten Blum <thorsten.blum@...lux.com>
Cc: linux-nilfs@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] nilfs2: Use div64_ul() instead of do_div()

On Fri, Mar 1, 2024 at 6:15 AM Thorsten Blum wrote:
>
>
> > On Feb 29, 2024, at 21:40, Thorsten Blum <thorsten.blum@...lux.com> wrote:
> >
> >> On Feb 29, 2024, at 20:41, Thorsten Blum <thorsten.blum@...lux.com> wrote:
> >>
> >>> On Feb 29, 2024, at 19:45, Ryusuke Konishi <konishi.ryusuke@...il.com> wrote:
> >>>
> >>> All of the fixes in this patch seem to be correct, but this doesn't
> >>> cover nilfs_resize_fs(), nilfs_max_segment_count(), and
> >>> nilfs_sb2_bad_offset(), which also have do_div() that doesn't use the
> >>> return value.
> >>
> >> For nilfs_sb2_bad_offset(), where the dividend is u64 and the divisor is u32, we
> >> would need a dedicated function like div64_u32() that doesn't calculate the
> >> remainder, which doesn't seem to exist. What do you think?
> >
> > Never mind, there is div_u64(u64, u32). I'll submit a v2 shortly.
>
> I left nilfs_sb2_bad_offset() unchanged in v2 because div_u64() still calculates
> the remainder.
>
> Thorsten

I got it.

I reviewed and tested the v2 patch and it was fine, so I sent it to
the -mm tree.

Thanks,
Ryusuke Konishi