linux-kernel - Re: [PATCH] cdrom: gdrom: Convert to platform remove callback returning void

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <170984014091.501426.12348420904865022114.b4-ty@kernel.dk>
Date: Thu, 07 Mar 2024 12:35:40 -0700
From: Jens Axboe <axboe@...nel.dk>
To: Hannes Reinecke <hare@...e.de>, Christian Brauner <brauner@...nel.org>, 
 Jack Wang <jinpu.wang@...os.com>, Phillip Potter <phil@...lpotter.co.uk>, 
 Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
Cc: Guenter Roeck <linux@...ck-us.net>, linux-kernel@...r.kernel.org, 
 kernel@...gutronix.de
Subject: Re: [PATCH] cdrom: gdrom: Convert to platform remove callback
 returning void


On Thu, 07 Mar 2024 19:08:37 +0100, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
> 
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new(), which already returns void. Eventually after all drivers
> are converted, .remove_new() will be renamed to .remove().
> 
> [...]

Applied, thanks!

[1/1] cdrom: gdrom: Convert to platform remove callback returning void
      commit: 0dc31b98d7200a0046de5c760feb0aaff6c4b53c

Best regards,
-- 
Jens Axboe