linux-kernel - Re: [PATCH net v5] ipv6: fib6_rules: flush route cache when rule is changed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5487d52a-31de-4422-b5ed-a59390d23ca0@kernel.org>
Date: Thu, 7 Mar 2024 12:36:53 -0700
From: David Ahern <dsahern@...nel.org>
To: Shiming Cheng <shiming.cheng@...iatek.com>, jiri@...nulli.us,
 kuba@...nel.org, pabeni@...hat.com, edumazet@...gle.com, davem@...emloft.net
Cc: linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
 Lena Wang <lena.wang@...iatek.com>
Subject: Re: [PATCH net v5] ipv6: fib6_rules: flush route cache when rule is
 changed

On 3/7/24 3:01 AM, Shiming Cheng wrote:
> When rule policy is changed, ipv6 socket cache is not refreshed.
> The sock's skb still uses a outdated route cache and was sent to
> a wrong interface.
> 
> To avoid this error we should update fib node's version when
> rule is changed. Then skb's route will be reroute checked as
> route cache version is already different with fib node version.
> The route cache is refreshed to match the latest rule.
> 
> Fixes: 101367c2f8c4 ("[IPV6]: Policy Routing Rules")
> Signed-off-by: Shiming Cheng <shiming.cheng@...iatek.com>
> Signed-off-by: Lena Wang <lena.wang@...iatek.com>
> ---
> v5:
>   - rebase on the top of latest net/main branch.
> v4:
>   - add "Fixes:" tag.
>   - update subject as requested.
> v3:
>   - update patch description and name format in commit message.
> v2:
>   - modify flush function same way as ipv4 flush cache.
>   - use tabs to aligh with existing code.
> ---
> ---
>  net/ipv6/fib6_rules.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 

Reviewed-by: David Ahern <dsahern@...nel.org>