linux-kernel - Re: [PATCH v7 5/7] scsi: hisi_sas: Add libsas SATA sysfs attributes group

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 7 Mar 2024 08:55:51 +0000
From: John Garry <john.g.garry@...cle.com>
To: Igor Pylypiv <ipylypiv@...gle.com>, Niklas Cassel <cassel@...nel.org>
Cc: Damien Le Moal <dlemoal@...nel.org>, Jason Yan <yanaijie@...wei.com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        Jack Wang <jinpu.wang@...ud.ionos.com>, Hannes Reinecke <hare@...e.de>,
        Xiang Chen <chenxiang66@...ilicon.com>,
        Artur Paszkiewicz <artur.paszkiewicz@...el.com>,
        Bart Van Assche <bvanassche@....org>, TJ Adams <tadamsjr@...gle.com>,
        linux-ide@...r.kernel.org, linux-scsi@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v7 5/7] scsi: hisi_sas: Add libsas SATA sysfs attributes
 group

On 06/03/2024 20:56, Igor Pylypiv wrote:
>>> ---
>>>   drivers/scsi/hisi_sas/hisi_sas_v2_hw.c | 6 ++++++
>>>   drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 6 ++++++
>> Is there a reason why you didn't patch:
>> drivers/scsi/hisi_sas/hisi_sas_v1_hw.c ?
>>
> I originally patched hisi_sas_v1_hw.c as well. John Garry pointed out
> that v1 HW doesn't support SATA so I dropped the change.

If you are going to do another spin, then maybe update the commit 
message with this.

Thanks,
John