linux-kernel - 回复: [PATCH v1 1/7] staging: media: starfive: Replaced current_fmt with get from sd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <SHXPR01MB0671F91D3D83EAB515B94CB0F220A@SHXPR01MB0671.CHNPR01.prod.partner.outlook.cn>
Date: Thu, 7 Mar 2024 01:58:49 +0000
From: Changhuang Liang <changhuang.liang@...rfivetech.com>
To: Dan Carpenter <dan.carpenter@...aro.org>
CC: Mauro Carvalho Chehab <mchehab@...nel.org>, Greg Kroah-Hartman
	<gregkh@...uxfoundation.org>, Hans Verkuil <hverkuil-cisco@...all.nl>,
	Laurent Pinchart <laurent.pinchart@...asonboard.com>, Jack Zhu
	<jack.zhu@...rfivetech.com>, "linux-media@...r.kernel.org"
	<linux-media@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "linux-staging@...ts.linux.dev"
	<linux-staging@...ts.linux.dev>
Subject:
 回复: [PATCH v1 1/7] staging: media: starfive: Replaced current_fmt with get from sd_state

Hi, Dan

Thanks for your comments.

> -----邮件原件-----
> 发件人: Dan Carpenter <dan.carpenter@...aro.org>
> 发送时间: 2024年3月6日 22:23
> 收件人: Changhuang Liang <changhuang.liang@...rfivetech.com>
> 抄送: Mauro Carvalho Chehab <mchehab@...nel.org>; Greg Kroah-Hartman
> <gregkh@...uxfoundation.org>; Hans Verkuil <hverkuil-cisco@...all.nl>;
> Laurent Pinchart <laurent.pinchart@...asonboard.com>; Jack Zhu
> <jack.zhu@...rfivetech.com>; linux-media@...r.kernel.org;
> linux-kernel@...r.kernel.org; linux-staging@...ts.linux.dev
> 主题: Re: [PATCH v1 1/7] staging: media: starfive: Replaced current_fmt with
> get from sd_state
> 
> On Wed, Mar 06, 2024 at 01:33:28AM -0800, Changhuang Liang wrote:
> > current_fmt only can store one pad format, when setting other pad it
> > will be overwrote. Replaced it with get from sd_state directly.
> >
> 
> These commit descriptions are kind of hard to understand so I have proposed
> new commit messages.
> 
> Subject: staging: media: starfive: Get rid of current_fmt
> 
> We want to support mutiple formats so saving one "current_fmt" doesn't
> work.  This was only used to set the ISP_REG_STRIDE so use the sd_state
> directly for that and delete the ->current_fmt pointer.  No functional change.
> 

I will re-change the patch description and add more details to all the patches.

Thanks