linux-kernel - 回复: [PATCH v1 2/7] staging: media: starfive: Add raw pad for ISP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <SHXPR01MB0671B1E1146F4262749ED88BF220A@SHXPR01MB0671.CHNPR01.prod.partner.outlook.cn>
Date: Thu, 7 Mar 2024 02:06:54 +0000
From: Changhuang Liang <changhuang.liang@...rfivetech.com>
To: Dan Carpenter <dan.carpenter@...aro.org>
CC: Mauro Carvalho Chehab <mchehab@...nel.org>, Greg Kroah-Hartman
	<gregkh@...uxfoundation.org>, Hans Verkuil <hverkuil-cisco@...all.nl>,
	Laurent Pinchart <laurent.pinchart@...asonboard.com>, Jack Zhu
	<jack.zhu@...rfivetech.com>, "linux-media@...r.kernel.org"
	<linux-media@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "linux-staging@...ts.linux.dev"
	<linux-staging@...ts.linux.dev>
Subject:
 回复: [PATCH v1 2/7] staging: media: starfive: Add raw pad for ISP

Hi Dan

> Re: [PATCH v1 2/7] staging: media: starfive: Add raw pad for ISP
> 
> On Wed, Mar 06, 2024 at 01:33:29AM -0800, Changhuang Liang wrote:
> > Add raw pad for ISP, it supported the conversion of RAW10 into RAW12.
> >
> 
> To be honest, I don't understand what "it supported the conversion of
> RAW10 into RAW12" means.  I don't think that this patch has any impact on
> user space but I'm not 100% sure.
> 

For StarFive ISP, the input format is RAW 10, which is converted to RAW 12 after ISP RAW pad output.

> A lot of this patch is just reformating stuff and it would be easier to review if
> the reformating were separated into a separate patch.
> 
> patch 2: Clean pad selection in isp_try_format()
> 
> The code to select isp_dev->formats[] is overly complicated.  We can just use
> the "pad" as the index.  This will making adding new pads easier in future
> patches.  No functional change.
> 
> patch 3: Add raw pad for ISP
> 

Yes, this patch can also be split into two patches

regards,
Changhuang