linux-kernel - 回复: [PATCH v1 5/7] staging: media: starfive: Add ISP raw video device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <SHXPR01MB06715A4810E596B068029472F220A@SHXPR01MB0671.CHNPR01.prod.partner.outlook.cn>
Date: Thu, 7 Mar 2024 02:13:50 +0000
From: Changhuang Liang <changhuang.liang@...rfivetech.com>
To: Dan Carpenter <dan.carpenter@...aro.org>
CC: Mauro Carvalho Chehab <mchehab@...nel.org>, Greg Kroah-Hartman
	<gregkh@...uxfoundation.org>, Hans Verkuil <hverkuil-cisco@...all.nl>,
	Laurent Pinchart <laurent.pinchart@...asonboard.com>, Jack Zhu
	<jack.zhu@...rfivetech.com>, "linux-media@...r.kernel.org"
	<linux-media@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "linux-staging@...ts.linux.dev"
	<linux-staging@...ts.linux.dev>
Subject:
 回复: [PATCH v1 5/7] staging: media: starfive: Add ISP raw video device

Hi, Dan

[...]
> >
> > +err_rm_links0:
> > +	media_entity_remove_links(&isp_dev->subdev.entity);
> 
> I don't think this line is correct.  I think we only need to remove
> &cap_yuv->video.vdev.entity.
> 

The instance I refer to needs to clear both the source entity and the sink entity. See
https://elixir.bootlin.com/linux/v6.8-rc7/source/drivers/media/platform/verisilicon/hantro_drv.c#L855

> > +	media_entity_remove_links(&cap_yuv->video.vdev.entity);
> >  err_cap_unregister:
> >  	stf_capture_unregister(stfcamss);
> >  err_isp_unregister:
> > @@ -162,6 +173,14 @@ static int stfcamss_register_devs(struct stfcamss
> > *stfcamss)
> >
> >  static void stfcamss_unregister_devs(struct stfcamss *stfcamss)  {
> > +	struct stf_capture *cap_yuv =
> &stfcamss->captures[STF_CAPTURE_YUV];
> > +	struct stf_capture *cap_raw =
> &stfcamss->captures[STF_CAPTURE_RAW];
> > +	struct stf_isp_dev *isp_dev = &stfcamss->isp_dev;
> > +
> > +	media_entity_remove_links(&isp_dev->subdev.entity);
> 
> I think this line should be deleted.
> 
> > +	media_entity_remove_links(&cap_raw->video.vdev.entity);
> > +	media_entity_remove_links(&cap_yuv->video.vdev.entity);
> 
> I think this "&cap_yuv" should be submitted by itself as a bugfix patch.
> 

Yes. 

Regards
Changhuang