linux-kernel - Re: [PATCH v4 07/11] drm/ci: meson: Refactor existing meson jobs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f6c1ced6-7f33-455d-9e7a-f26608241372@collabora.com>
Date: Thu, 7 Mar 2024 11:02:33 -0300
From: Helen Koike <helen.koike@...labora.com>
To: Vignesh Raman <vignesh.raman@...labora.com>,
 dri-devel@...ts.freedesktop.org
Cc: daniels@...labora.com, airlied@...il.com, daniel@...ll.ch,
 emma@...olt.net, robdclark@...il.com, david.heidelberg@...labora.com,
 guilherme.gallo@...labora.com, sergi.blanch.torne@...labora.com,
 hamohammed.sa@...il.com, rodrigosiqueiramelo@...il.com,
 melissa.srw@...il.com, mairacanal@...eup.net, mcanal@...lia.com,
 linux-mediatek@...ts.infradead.org, linux-amlogic@...ts.infradead.org,
 linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 07/11] drm/ci: meson: Refactor existing meson jobs



On 06/03/2024 00:06, Vignesh Raman wrote:
> For Amlogic Meson SOC the display driver is meson. Currently,
> in drm-ci for meson, only the display driver is tested.
> Refactor the existing meson jobs so that gpu driver testing
> jobs can be added later and update xfails accordingly.
> 
> Signed-off-by: Vignesh Raman <vignesh.raman@...labora.com>
> ---
> 
> v2:
>    - Refactor the patch to rename job to indicate display driver testing,
>      rename the existing xfail files.
> 
> v3:
>    - Add the job name in GPU_VERSION and use it for xfail file names instead
>      of using DRIVER_NAME.
> 
> v4:
>    - Remove the display suffix in job and rename xfails accordingly.
>      Remove the change adding job name in GPU_VERSION.
> 
> ---
>   drivers/gpu/drm/ci/test.yml                    | 11 ++++++++---
>   drivers/gpu/drm/ci/xfails/meson-g12b-fails.txt |  5 -----
>   2 files changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/gpu/drm/ci/test.yml b/drivers/gpu/drm/ci/test.yml
> index 99fd101ce2fe..951a44bf9d19 100644
> --- a/drivers/gpu/drm/ci/test.yml
> +++ b/drivers/gpu/drm/ci/test.yml
> @@ -351,20 +351,25 @@ panfrost:mt8183:
>       - .lava-igt:arm64
>     stage: meson
>     variables:
> -    DRIVER_NAME: meson
>       DTB: ${DEVICE_TYPE}
>       BOOT_METHOD: u-boot
>       KERNEL_IMAGE_TYPE: "image"
>   
> -meson:g12b:
> +.g12b:
>     extends:
>       - .meson
>     parallel: 3
>     variables:
>       DEVICE_TYPE: meson-g12b-a311d-khadas-vim3
> -    GPU_VERSION: g12b

Looks like it make sense to keep GPU_VERSION here, no?

Regards,
Helen

>       RUNNER_TAG: mesa-ci-x86-64-lava-meson-g12b-a311d-khadas-vim3
>   
> +meson:g12b:
> +  extends:
> +    - .g12b
> +  variables:
> +    GPU_VERSION: g12b
> +    DRIVER_NAME: meson
> +
>   virtio_gpu:none:
>     stage: virtio-gpu
>     variables:
> diff --git a/drivers/gpu/drm/ci/xfails/meson-g12b-fails.txt b/drivers/gpu/drm/ci/xfails/meson-g12b-fails.txt
> index 56a2ae7047b4..029b4ade21f6 100644
> --- a/drivers/gpu/drm/ci/xfails/meson-g12b-fails.txt
> +++ b/drivers/gpu/drm/ci/xfails/meson-g12b-fails.txt
> @@ -5,11 +5,6 @@ kms_cursor_legacy@...gle-bo,Fail
>   kms_cursor_legacy@...gle-move,Fail
>   kms_cursor_legacy@...ture-bo,Fail
>   kms_cursor_legacy@...ture-move,Fail
> -kms_force_connector_basic@...ce-edid,Fail
> -kms_hdmi_inject@...ect-4k,Fail
> -kms_plane_cursor@...rlay,Fail
> -kms_plane_cursor@...mary,Fail
> -kms_plane_cursor@...wport,Fail
>   kms_properties@...nector-properties-atomic,Fail
>   kms_properties@...nector-properties-legacy,Fail
>   kms_properties@..._properties-sanity-atomic,Fail