linux-kernel - Re: [PATCH v4 05/11] drm/ci: mediatek: Refactor existing mediatek jobs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <e53fd362-c2c2-4935-b6a3-c73decd23d10@collabora.com>
Date: Thu, 7 Mar 2024 11:02:27 -0300
From: Helen Koike <helen.koike@...labora.com>
To: Vignesh Raman <vignesh.raman@...labora.com>,
 dri-devel@...ts.freedesktop.org
Cc: daniels@...labora.com, airlied@...il.com, daniel@...ll.ch,
 emma@...olt.net, robdclark@...il.com, david.heidelberg@...labora.com,
 guilherme.gallo@...labora.com, sergi.blanch.torne@...labora.com,
 hamohammed.sa@...il.com, rodrigosiqueiramelo@...il.com,
 melissa.srw@...il.com, mairacanal@...eup.net, mcanal@...lia.com,
 linux-mediatek@...ts.infradead.org, linux-amlogic@...ts.infradead.org,
 linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 05/11] drm/ci: mediatek: Refactor existing mediatek
 jobs



On 06/03/2024 00:06, Vignesh Raman wrote:
> For mediatek mt8173 and mt8183, the display driver is mediatek.
> Currently, in drm-ci for mediatek, only the display driver is
> tested. Refactor the existing mediatek jobs so that gpu driver
> testing jobs can be added later and update xfails accordingly.
> Since the correct driver name is passed from the job to test gpu
> and display driver, remove the check to set IGT_FORCE_DRIVER
> based on driver name.
> 
> Signed-off-by: Vignesh Raman <vignesh.raman@...labora.com>
> ---
> 
> v2:
>    - Refactor the patch to rename job to indicate display driver testing,
>      rename the existing xfail files, and remove IGT_FORCE_DRIVER from the
>      script since it's now set by the job.
> 
> v3:
>    - Add the job name in GPU_VERSION and use it for xfail file names instead
>      of using DRIVER_NAME. Also update xfails.
> 
> v4:
>    - Remove the display suffix in job and rename xfails accordingly.
>      Remove the change adding job name in GPU_VERSION.
> 
> ---
>   drivers/gpu/drm/ci/igt_runner.sh              | 10 ---------
>   drivers/gpu/drm/ci/test.yml                   | 21 ++++++++++++++-----
>   .../drm/ci/xfails/mediatek-mt8173-fails.txt   | 15 -------------
>   .../drm/ci/xfails/mediatek-mt8173-flakes.txt  | 13 ++++++++++++
>   .../drm/ci/xfails/mediatek-mt8183-fails.txt   | 21 ++++++++++++-------
>   .../drm/ci/xfails/mediatek-mt8183-flakes.txt  |  8 +++++++
>   6 files changed, 50 insertions(+), 38 deletions(-)
>   create mode 100644 drivers/gpu/drm/ci/xfails/mediatek-mt8173-flakes.txt
>   create mode 100644 drivers/gpu/drm/ci/xfails/mediatek-mt8183-flakes.txt
> 
> diff --git a/drivers/gpu/drm/ci/igt_runner.sh b/drivers/gpu/drm/ci/igt_runner.sh
> index 77cd81fe6d1a..711f32772e48 100755
> --- a/drivers/gpu/drm/ci/igt_runner.sh
> +++ b/drivers/gpu/drm/ci/igt_runner.sh
> @@ -20,16 +20,6 @@ cat /sys/kernel/debug/dri/*/state
>   set -e
>   
>   case "$DRIVER_NAME" in
> -    rockchip|meson)
> -        export IGT_FORCE_DRIVER="panfrost"
> -        ;;
> -    mediatek)
> -        if [ "$GPU_VERSION" = "mt8173" ]; then
> -            export IGT_FORCE_DRIVER=${DRIVER_NAME}
> -        elif [ "$GPU_VERSION" = "mt8183" ]; then
> -            export IGT_FORCE_DRIVER="panfrost"
> -        fi
> -        ;;
>       amdgpu)
>           # Cannot use HWCI_KERNEL_MODULES as at that point we don't have the module in /lib
>           mv /install/modules/lib/modules/* /lib/modules/.
> diff --git a/drivers/gpu/drm/ci/test.yml b/drivers/gpu/drm/ci/test.yml
> index 0857773e5c5f..f8f48523ada3 100644
> --- a/drivers/gpu/drm/ci/test.yml
> +++ b/drivers/gpu/drm/ci/test.yml
> @@ -282,29 +282,40 @@ amdgpu:stoney:
>       - .lava-igt:arm64
>     stage: mediatek
>     variables:
> -    DRIVER_NAME: mediatek
>       DTB: ${DEVICE_TYPE}
>       BOOT_METHOD: depthcharge
>       KERNEL_IMAGE_TYPE: ""
>   
> -mediatek:mt8173:
> +.mt8173:
>     extends:
>       - .mediatek
>     parallel: 4
>     variables:
>       DEVICE_TYPE: mt8173-elm-hana
> -    GPU_VERSION: mt8173

Looks like it make sense to keep GPU_VERSION here, no?
Same comment for .mt8183.

Regards,
Helen

>       RUNNER_TAG: mesa-ci-x86-64-lava-mt8173-elm-hana
>   
> -mediatek:mt8183:
> +.mt8183:
>     extends:
>       - .mediatek
>     parallel: 3
>     variables:
>       DEVICE_TYPE: mt8183-kukui-jacuzzi-juniper-sku16
> -    GPU_VERSION: mt8183
>       RUNNER_TAG: mesa-ci-x86-64-lava-mt8183-kukui-jacuzzi-juniper-sku16
>   
> +mediatek:mt8173:
> +  extends:
> +    - .mt8173
> +  variables:
> +    GPU_VERSION: mt8173
> +    DRIVER_NAME: mediatek
> +
> +mediatek:mt8183:
> +  extends:
> +    - .mt8183
> +  variables:
> +    GPU_VERSION: mt8183
> +    DRIVER_NAME: mediatek
> +
>   # drm-mtk doesn't even probe yet in mainline for mt8192
>   .mediatek:mt8192:
>     extends:
> diff --git a/drivers/gpu/drm/ci/xfails/mediatek-mt8173-fails.txt b/drivers/gpu/drm/ci/xfails/mediatek-mt8173-fails.txt
> index ef0cb7c3698c..c63abd603b02 100644
> --- a/drivers/gpu/drm/ci/xfails/mediatek-mt8173-fails.txt
> +++ b/drivers/gpu/drm/ci/xfails/mediatek-mt8173-fails.txt
> @@ -9,28 +9,13 @@ kms_bw@...ear-tiling-3-displays-1920x1080p,Fail
>   kms_bw@...ear-tiling-3-displays-2560x1440p,Fail
>   kms_bw@...ear-tiling-3-displays-3840x2160p,Fail
>   kms_color@...alid-gamma-lut-sizes,Fail
> -kms_color@...e-A-invalid-gamma-lut-sizes,Fail
> -kms_color@...e-B-invalid-gamma-lut-sizes,Fail
>   kms_cursor_legacy@...sor-vs-flip-atomic,Fail
>   kms_cursor_legacy@...sor-vs-flip-legacy,Fail
>   kms_flip@...p-vs-modeset-vs-hang,Fail
>   kms_flip@...p-vs-panning-vs-hang,Fail
>   kms_flip@...p-vs-suspend,Fail
>   kms_flip@...p-vs-suspend-interruptible,Fail
> -kms_force_connector_basic@...ce-edid,Fail
> -kms_force_connector_basic@...ce-load-detect,Fail
> -kms_force_connector_basic@...ne-stale-modes,Fail
> -kms_hdmi_inject@...ect-4k,Fail
> -kms_plane_scaling@...nes-upscale-20x20,Fail
> -kms_plane_scaling@...nes-upscale-20x20-downscale-factor-0-25,Fail
> -kms_plane_scaling@...nes-upscale-20x20-downscale-factor-0-5,Fail
> -kms_plane_scaling@...nes-upscale-20x20-downscale-factor-0-75,Fail
> -kms_plane_scaling@...cale-with-modifier-20x20,Fail
> -kms_plane_scaling@...cale-with-pixel-format-20x20,Fail
> -kms_plane_scaling@...cale-with-rotation-20x20,Fail
>   kms_properties@..._properties-sanity-atomic,Fail
>   kms_properties@...ne-properties-atomic,Fail
>   kms_properties@...ne-properties-legacy,Fail
>   kms_rmfb@...se-fd,Fail
> -kms_selftest@..._format,Timeout
> -kms_selftest@..._format_helper,Timeout
> diff --git a/drivers/gpu/drm/ci/xfails/mediatek-mt8173-flakes.txt b/drivers/gpu/drm/ci/xfails/mediatek-mt8173-flakes.txt
> new file mode 100644
> index 000000000000..64b30c092c85
> --- /dev/null
> +++ b/drivers/gpu/drm/ci/xfails/mediatek-mt8173-flakes.txt
> @@ -0,0 +1,13 @@
> +# Board Name: mt8173-elm-hana.dtb
> +# Bug Report: https://lore.kernel.org/dri-devel/931e3f9a-9c5c-fc42-16fc-abaac4e0c0ff@collabora.com/T/#u
> +# IGT Version: 1.28-gd2af13d9f
> +# Failure Rate: 50
> +# Linux Version: 6.7.0-rc3
> +
> +# Reported by deqp-runner
> +kms_cursor_legacy@...sor-vs-flip-atomic-transitions
> +
> +# Below test shows inconsistency across multiple runs,
> +# giving results of Pass and Timeout/Fail alternately
> +kms_prop_blob@...alid-set-prop
> +kms_prop_blob@...alid-set-prop-any
> diff --git a/drivers/gpu/drm/ci/xfails/mediatek-mt8183-fails.txt b/drivers/gpu/drm/ci/xfails/mediatek-mt8183-fails.txt
> index 67d690fc4037..28c825c9cd60 100644
> --- a/drivers/gpu/drm/ci/xfails/mediatek-mt8183-fails.txt
> +++ b/drivers/gpu/drm/ci/xfails/mediatek-mt8183-fails.txt
> @@ -1,13 +1,18 @@
> -kms_addfb_basic@...fb25-bad-modifier,Fail
> +core_setmaster_vs_auth,Fail
> +kms_bw@...ear-tiling-1-displays-1920x1080p,Fail
>   kms_bw@...ear-tiling-1-displays-2560x1440p,Fail
> +kms_bw@...ear-tiling-1-displays-3840x2160p,Fail
>   kms_bw@...ear-tiling-2-displays-1920x1080p,Fail
>   kms_bw@...ear-tiling-2-displays-2560x1440p,Fail
>   kms_bw@...ear-tiling-2-displays-3840x2160p,Fail
> -kms_bw@...ear-tiling-3-displays-2560x1440p,Fail
> -kms_bw@...ear-tiling-3-displays-3840x2160p,Fail
> -kms_color@...e-A-invalid-gamma-lut-sizes,Fail
> -kms_plane_cursor@...rlay,Fail
> -kms_plane_cursor@...mary,Fail
> -kms_plane_cursor@...wport,Fail
> -kms_plane_scaling@...cale-with-rotation-20x20,Fail
> +kms_color@...alid-gamma-lut-sizes,Fail
> +kms_cursor_legacy@...sor-vs-flip-atomic,Fail
> +kms_cursor_legacy@...sor-vs-flip-legacy,Fail
> +kms_flip@...p-vs-modeset-vs-hang,Fail
> +kms_flip@...p-vs-panning-vs-hang,Fail
> +kms_flip@...p-vs-suspend,Fail
> +kms_prop_blob@...alid-set-prop-any,Fail
> +kms_properties@..._properties-sanity-atomic,Fail
> +kms_properties@...ne-properties-atomic,Fail
> +kms_properties@...ne-properties-legacy,Fail
>   kms_rmfb@...se-fd,Fail
> diff --git a/drivers/gpu/drm/ci/xfails/mediatek-mt8183-flakes.txt b/drivers/gpu/drm/ci/xfails/mediatek-mt8183-flakes.txt
> new file mode 100644
> index 000000000000..5885a950fa72
> --- /dev/null
> +++ b/drivers/gpu/drm/ci/xfails/mediatek-mt8183-flakes.txt
> @@ -0,0 +1,8 @@
> +# Board Name: mt8183-kukui-jacuzzi-juniper-sku16.dtb
> +# Bug Report: https://lore.kernel.org/dri-devel/931e3f9a-9c5c-fc42-16fc-abaac4e0c0ff@collabora.com/T/#u
> +# IGT Version: 1.28-gd2af13d9f
> +# Failure Rate: 100
> +# Linux Version: 6.7.0-rc3
> +
> +# Reported by deqp-runner
> +kms_cursor_legacy@...sor-vs-flip-atomic-transitions