linux-kernel - Re: [EXT] Re: [PATCH v7 04/11] dt-bindings: usb: ci-hdrc-usb2-imx: move imx parts to dedicated schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <79b33edb-2474-461b-b848-6c526bd3bdbe@linaro.org>
Date: Fri, 8 Mar 2024 09:38:02 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Xu Yang <xu.yang_2@....com>,
 "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
 "robh+dt@...nel.org" <robh+dt@...nel.org>,
 "krzysztof.kozlowski+dt@...aro.org" <krzysztof.kozlowski+dt@...aro.org>,
 "shawnguo@...nel.org" <shawnguo@...nel.org>,
 "conor+dt@...nel.org" <conor+dt@...nel.org>
Cc: "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
 "kernel@...gutronix.de" <kernel@...gutronix.de>,
 "festevam@...il.com" <festevam@...il.com>, dl-linux-imx <linux-imx@....com>,
 "peter.chen@...nel.org" <peter.chen@...nel.org>, Jun Li <jun.li@....com>,
 "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
 "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
 "linux-arm-kernel@...ts.infradead.org"
 <linux-arm-kernel@...ts.infradead.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [EXT] Re: [PATCH v7 04/11] dt-bindings: usb: ci-hdrc-usb2-imx:
 move imx parts to dedicated schema

On 08/03/2024 09:30, Xu Yang wrote:
>>> +          - enum:
>>> +              - fsl,imx8mm-usb
>>> +              - fsl,imx8mn-usb
>>> +          - const: fsl,imx7d-usb
>>> +          - const: fsl,imx27-usb
>>> +      - items:
>>> +          - enum:
>>> +              - fsl,imx6sll-usb
>>> +              - fsl,imx7ulp-usb
>>> +          - const: fsl,imx6ul-usb
>>> +          - const: fsl,imx27-usb
>>> +
>>> +  clocks:
>>> +    minItems: 1
>>> +    maxItems: 3
>>
>>
>> No need to, it's already in common. Drop clocks.
> 
> No. I cannot remove clocks property in this yaml since the usb node may use assigned-clocks
> and assigned-clock-parents. Then dtschema will have warning like below patch:
> https://lore.kernel.org/all/20230508071837.68552-1-krzysztof.kozlowski@linaro.org/

This was a year ago, so please check if it is still the case. With
latest dtschema. If it is still the case, then indeed keep clocks here.

Best regards,
Krzysztof