linux-kernel - Re: regression/bisected/6.8 commit 5d390df3bdd13d178eb2e02e60e9a480f7103f7b prevents the system going into suspend mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABXGCsOPPuDSSLsOpzvzv+t8yL9z-gzoMTBY0wAL-s1Cd+bDyg@mail.gmail.com>
Date: Fri, 8 Mar 2024 17:48:04 +0500
From: Mikhail Gavrilov <mikhail.v.gavrilov@...il.com>
To: Alexey Dobriyan <adobriyan@...il.com>
Cc: stfrench@...rosoft.com, 
	Linux List Kernel Mailing <linux-kernel@...r.kernel.org>
Subject: Re: regression/bisected/6.8 commit 5d390df3bdd13d178eb2e02e60e9a480f7103f7b
 prevents the system going into suspend mode

On Fri, Mar 8, 2024 at 11:15 AM Alexey Dobriyan <adobriyan@...il.com> wrote:
>
> What? Deleting unused defines breaks suspend?
>
> Collect fs/smb/client/smbencrypt.o with and without patch and
> see them being identical.
>
> Enum in stddef.h are
>
>         enum {
>                 false = 0,
>                 true = 1,
>         };
>
> so if defines were used somehow they would expand to same values of
> same type.
>
> Something else is going on.

I understand your confusion.
But I didn't come up with it. And moreover, I saw what the revert does.

diff --git a/fs/smb/client/smbencrypt.c b/fs/smb/client/smbencrypt.c
index 1d1ee9f18f37..f0ce26414f17 100644
--- a/fs/smb/client/smbencrypt.c
+++ b/fs/smb/client/smbencrypt.c
@@ -26,6 +26,13 @@
 #include "cifsproto.h"
 #include "../common/md4.h"

+#ifndef false
+#define false 0
+#endif
+#ifndef true
+#define true 1
+#endif
+
 /* following came from the other byteorder.h to avoid include conflicts */
 #define CVAL(buf,pos) (((unsigned char *)(buf))[pos])
 #define SSVALX(buf,pos,val) (CVAL(buf,pos)=(val)&0xFF,CVAL(buf,pos+1)=(val)>>8)

Why did this really help is a question to which I would like to find an answer.

The most interesting thing is that I have two identical systems:
Identical:
- M/B - MSI MPG B650I EDGE WIFI
- CPU - AMD Ryzen 7950x
- GPU - AMD Radeon 7900XTX
- SSD1 for system - Intel Optane 905P SSDPE21D480GAM3
- SSD2 for data - Intel D5 P5316 Series SSDPF2NV307TZN1
- PSU - Asus ROG LOKI SFX-L 1000W Platinum
- Mouse - Logitech MX Master 3s
- Keyboard - MX Keys Mini
- Linux distro (identical version of all software) - Fedora Rawhide
On one system this bug is present, on the other it is not.

Affected system: https://linux-hardware.org/?probe=9a5a8c0338
Not affected system: https://linux-hardware.org/?probe=37c62300bb

-- 
Best Regards,
Mike Gavrilov.