linux-kernel - [PATCH v3] Staging: rtl8192e: Declare variable with static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240309174722.3463-1-arielsilver77@gmail.com>
Date: Sat,  9 Mar 2024 19:47:22 +0200
From: Ariel Silver <arielsilver77@...il.com>
To: gregkh@...uxfoundation.org,
	philipp.g.hortmann@...il.com,
	yogi.kernel@...il.com,
	straube.linux@...il.com,
	dan.carpenter@...aro.org
Cc: linux-staging@...ts.linux.de,
	linux-kernel@...r.kernel.org,
	Ariel Silver <arielsilver77@...il.com>
Subject: [PATCH v3] Staging: rtl8192e: Declare variable with static

Fixed sparse warning:
"'dm_rx_path_sel_table' was not declared. Should it be static?"
As dm_rx_path_sel_table is used only in rtl_dm.c it should be static.

Signed-off-by: Ariel Silver <arielsilver77@...il.com>
---
V2 -> V3: add patch version number and changelog
V1 -> V2: fix checkpatch.pl warnings
---
 drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c
index 330dafd62656..5b52bc992a61 100644
--- a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c
+++ b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c
@@ -144,7 +144,7 @@ const u8 dm_cck_tx_bb_gain_ch14[CCK_TX_BB_GAIN_TABLE_LEN][8] = {
 /*------------------------Define global variable-----------------------------*/
 struct dig_t dm_digtable;
 
-struct drx_path_sel dm_rx_path_sel_table;
+static struct drx_path_sel dm_rx_path_sel_table;
 /*------------------------Define global variable-----------------------------*/
 
 
-- 
2.25.1