linux-kernel - Re: [PATCH v3] Staging: rtl8192e: Declare variable with static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7b52b937-787a-45eb-a8ba-e96f4aad006a@gmail.com>
Date: Sun, 10 Mar 2024 09:38:47 +0100
From: Philipp Hortmann <philipp.g.hortmann@...il.com>
To: Ariel Silver <arielsilver77@...il.com>, gregkh@...uxfoundation.org,
 yogi.kernel@...il.com, straube.linux@...il.com, dan.carpenter@...aro.org
Cc: linux-staging@...ts.linux.de, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] Staging: rtl8192e: Declare variable with static

On 3/9/24 18:47, Ariel Silver wrote:
> Fixed sparse warning:
> "'dm_rx_path_sel_table' was not declared. Should it be static?"
> As dm_rx_path_sel_table is used only in rtl_dm.c it should be static.
> 
> Signed-off-by: Ariel Silver <arielsilver77@...il.com>
> ---
> V2 -> V3: add patch version number and changelog
> V1 -> V2: fix checkpatch.pl warnings
> ---
>   drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c
> index 330dafd62656..5b52bc992a61 100644
> --- a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c
> +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c
> @@ -144,7 +144,7 @@ const u8 dm_cck_tx_bb_gain_ch14[CCK_TX_BB_GAIN_TABLE_LEN][8] = {
>   /*------------------------Define global variable-----------------------------*/
>   struct dig_t dm_digtable;
>   
> -struct drx_path_sel dm_rx_path_sel_table;
> +static struct drx_path_sel dm_rx_path_sel_table;
>   /*------------------------Define global variable-----------------------------*/
>   
>   


Tested-by: Philipp Hortmann <philipp.g.hortmann@...il.com>