linux-kernel - Re: [PATCH v6 0/2] zswap: remove the memcpy if acomp is not sleepable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Sat, 9 Mar 2024 13:08:14 +0800
From: Barry Song <21cnbao@...il.com>
To: Andrew Morton <akpm@...ux-foundation.org>
Cc: herbert@...dor.apana.org.au, chriscli@...gle.com, chrisl@...nel.org, 
	ddstreet@...e.org, linux-kernel@...r.kernel.org, sjenning@...hat.com, 
	vitaly.wool@...sulko.com, Barry Song <v-songbaohua@...o.com>, davem@...emloft.net, 
	hannes@...xchg.org, linux-crypto@...r.kernel.org, linux-mm@...ck.org, 
	zhouchengming@...edance.com, nphamcs@...il.com, yosryahmed@...gle.com
Subject: Re: [PATCH v6 0/2] zswap: remove the memcpy if acomp is not sleepable

On Sat, Mar 9, 2024 at 12:56 PM Barry Song <21cnbao@...il.com> wrote:
>
> On Sat, Mar 9, 2024 at 12:42 PM Andrew Morton <akpm@...ux-foundation.org> wrote:
> >
> > On Fri, 8 Mar 2024 20:36:41 -0800 Andrew Morton <akpm@...ux-foundation.org> wrote:
> >
> > > > Okay, I understand. Since this patch improves zswap's performance, I wanted
> > > > it to be integrated sooner to contribute. However, I'm perfectly willing to
> > > > respect your concerns and adhere to the community's best practices.
> > > >
> > >
> > > OK.  I very much doubt if anyone is running those drivers on mm.git, so
> > > adding it now isn't likely to hurt.
> > >
> > > So I'll merge it now and shall aim to get it upstream very late in the
> > > next merge window.
> >
> > Nope.  mm.git won't build without acomp_is_async().
> >
> > We can merge the zswap patch via the crypto tree.  Acked-by: me.
>
> Herbert Acked the acomp_is_async() patch in v5 instead of picking it up
> into crypto:
> https://lore.kernel.org/linux-mm/ZdWKz43tTz2XY4ca@gondor.apana.org.au/

More details: Herbert acked the acomp_is_async in v5 [1], while he requested
that patch 3/3 of v5 be split from the series and applied by crypto
[2]. Patch 3/3
of v5 can function independently of 1/3 and 2/3, and it has already
been included
in the crypto tree.

That is why v6 has only two left.

[1] https://lore.kernel.org/linux-mm/ZdWKz43tTz2XY4ca@gondor.apana.org.au/
[2] https://lore.kernel.org/linux-mm/ZdWLim6zYSl%2Fx1Bk@gondor.apana.org.au/


>
> >
> > Or please just resend the zswap change after 6.9-rc1 is released.

Thanks
Barry