linux-kernel - Re: [PATCH 1/2] clk: qcom: clk-alpha-pll: remove invalid Stromer register offset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <301380ee-1c93-49b4-b4e1-3b1289e98a75@linaro.org>
Date: Tue, 12 Mar 2024 01:01:50 +0100
From: Konrad Dybcio <konrad.dybcio@...aro.org>
To: Gabor Juhos <j4g8y7@...il.com>, Bjorn Andersson <andersson@...nel.org>,
 Michael Turquette <mturquette@...libre.com>, Stephen Boyd
 <sboyd@...nel.org>, Varadarajan Narayanan <quic_varada@...cinc.com>,
 Sricharan R <quic_srichara@...cinc.com>,
 Kathiravan T <quic_kathirav@...cinc.com>
Cc: linux-arm-msm@...r.kernel.org, linux-clk@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] clk: qcom: clk-alpha-pll: remove invalid Stromer
 register offset



On 3/11/24 19:45, Gabor Juhos wrote:
> The offset of the CONFIG_CTL_U register defined for the Stromer
> PLL is wrong. It is not aligned on a 4 bytes boundary which might
> causes errors in regmap operations.
> 
> Maybe the intention behind of using the 0xff value was to indicate
> that the register is not implemented in the PLL, but this is not
> verified anywhere in the code. Moreover, this value is not used
> even in other register offset arrays despite that those PLLs also
> have unimplemented registers.
> 
> Additionally, on the Stromer PLLs the current code only touches
> the CONFIG_CTL_U register if the result of pll_has_64bit_config()
> is true which condition is not affected by the change.
> 
> Due to the reasons above, simply remove the CONFIG_CTL_U entry
> from the Stromer specific array.
> 
> Fixes: e47a4f55f240 ("clk: qcom: clk-alpha-pll: Add support for Stromer PLLs")
> Signed-off-by: Gabor Juhos <j4g8y7@...il.com>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@...aro.org>

Konrad>