linux-kernel - Re: [PATCH v2 1/2] dt-bindings: pinctrl: qcom: update compatible name for match with driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2b512404-bc56-41b8-89aa-dcbb23d7b2bd@quicinc.com>
Date: Mon, 11 Mar 2024 17:43:22 +0800
From: Tengfei Fan <quic_tengfan@...cinc.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Linus Walleij
	<linus.walleij@...aro.org>,
        Rob Herring <robh+dt@...nel.org>
CC: <andersson@...nel.org>, <konrad.dybcio@...aro.org>,
        <krzysztof.kozlowski+dt@...aro.org>, <conor+dt@...nel.org>,
        <linux-arm-msm@...r.kernel.org>, <linux-gpio@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <kernel@...cinc.com>
Subject: Re: [PATCH v2 1/2] dt-bindings: pinctrl: qcom: update compatible name
 for match with driver



On 3/11/2024 2:48 PM, Krzysztof Kozlowski wrote:
> On 11/03/2024 03:27, Tengfei Fan wrote:
>>
>>
>> On 3/10/2024 7:44 AM, Linus Walleij wrote:
>>> On Fri, Mar 8, 2024 at 9:10 PM Rob Herring <robh+dt@...nel.org> wrote:
>>>> On Tue, Feb 27, 2024 at 7:37 AM Rob Herring <robh+dt@...nel.org> wrote:
>>>>> On Mon, Jan 29, 2024 at 3:25 AM Tengfei Fan <quic_tengfan@...cinc.com> wrote:
>>>>>>
>>>>>> Use compatible name "qcom,sm4450-tlmm" instead of "qcom,sm4450-pinctrl"
>>>>>> to match the compatible name in sm4450 pinctrl driver.
>>>>>>
>>>>>> Fixes: 7bf8b78f86db ("dt-bindings: pinctrl: qcom: Add SM4450 pinctrl")
>>>>>> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
>>>>>> Signed-off-by: Tengfei Fan <quic_tengfan@...cinc.com>
>>>>>> ---
>>>>>>    Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmm.yaml | 2 +-
>>>>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>>>>
>>>>>> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmm.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmm.yaml
>>>>>> index bb08ca5a1509..bb675c8ec220 100644
>>>>>> --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmm.yaml
>>>>>> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmm.yaml
>>>>>> @@ -17,7 +17,7 @@ allOf:
>>>>>>
>>>>>>    properties:
>>>>>>      compatible:
>>>>>> -    const: qcom,sm4450-pinctrl
>>>>>> +    const: qcom,sm4450-tlmm
>>>>>
>>>>> I think you forgot to update the example:
>>>>>
>>>>> Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmm.example.dtb:
>>>>> /example-0/pinctrl@...0000: failed to match any schema with
>>>>> compatible: ['qcom,sm4450-tlmm']
>>>>
>>>> Still a warning in linux-next. Please send a fix.
>>>
>>> I understand it as applying 1/2 is the fix so I applied it.
>>
>> I will check this warning, and I will fix it.
> 
> Now? We were all waiting for you to respond here without any effect, so
> finally I asked Linus to take the patch. In the future, be responsible
> for your patches and comments happening to them. The same if your
> applied commit causes issues in the next.

I will speed up the upstream work of the sm4450.
Before that, I had been focusing on the work of AIM300.

> 
> Best regards,
> Krzysztof
> 

-- 
Thx and BRs,
Tengfei Fan