[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20240311030735.233470-1-richard120310@gmail.com>
Date: Mon, 11 Mar 2024 11:07:35 +0800
From: I-HSIN CHENG <richard120310@...il.com>
To: philipp.reisner@...bit.com
Cc: lars.ellenberg@...bit.com,
christoph.boehmwalder@...bit.com,
drbd-dev@...ts.linbit.com,
linux-kernel@...r.kernel.org,
I-HSIN CHENG <richard120310@...il.com>
Subject: [PATCH] lru_cache: Initialize hlist_head in lc_create
Use INIT_HLIST_HEAD to perform the initialization for each pointer to
struct list_head in the variable "slot" to provide more safety and
prevent possible bugs from uninitialized behavior.
Signed-off-by: I-HSIN CHENG <richard120310@...il.com>
---
lib/lru_cache.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/lib/lru_cache.c b/lib/lru_cache.c
index b3d918761..f2197aae1 100644
--- a/lib/lru_cache.c
+++ b/lib/lru_cache.c
@@ -105,6 +105,9 @@ struct lru_cache *lc_create(const char *name, struct kmem_cache *cache,
if (!lc)
goto out_fail;
+ for (int i = 0; i < e_count; i++)
+ INIT_HLIST_HEAD(slot + (i * sizeof(struct hlist_head)));
+
INIT_LIST_HEAD(&lc->in_use);
INIT_LIST_HEAD(&lc->lru);
INIT_LIST_HEAD(&lc->free);
--
2.34.1
Powered by blists - more mailing lists