linux-kernel - Re: [PATCH] lru_cache: Initialize hlist_head in lc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Zh6AOaymY1kF+V8F@grappa.linbit>
Date: Tue, 16 Apr 2024 15:42:17 +0200
From: Lars Ellenberg <lars.ellenberg@...bit.com>
To: I-HSIN CHENG <richard120310@...il.com>
Cc: philipp.reisner@...bit.com, christoph.boehmwalder@...bit.com,
	drbd-dev@...ts.linbit.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] lru_cache: Initialize hlist_head in lc_create

On Mon, Mar 11, 2024 at 11:07:35AM +0800, I-HSIN CHENG wrote:
> Use INIT_HLIST_HEAD to perform the initialization for each pointer to
> struct list_head in the variable "slot" to provide more safety and
> prevent possible bugs from uninitialized behavior.

Completely pointless.  It is kcalloc'd.  Why explicitly zero-out something
that was already explicitly zeroed out to begin with.

    Lars