linux-kernel - Re: [PATCH 5.10/5.15] io_uring: fix registered files leak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fb57be64-4da6-418b-9369-eae0db42a570@kernel.dk>
Date: Tue, 12 Mar 2024 09:21:30 -0600
From: Jens Axboe <axboe@...nel.dk>
To: Fedor Pchelkin <pchelkin@...ras.ru>
Cc: Pavel Begunkov <asml.silence@...il.com>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>, stable@...r.kernel.org,
 io-uring@...r.kernel.org, linux-kernel@...r.kernel.org,
 Alexey Khoroshilov <khoroshilov@...ras.ru>, lvc-project@...uxtesting.org,
 Nikita Zhandarovich <n.zhandarovich@...tech.ru>,
 Roman Belyaev <belyaevrd@...dex.ru>
Subject: Re: [PATCH 5.10/5.15] io_uring: fix registered files leak

On 3/12/24 9:14 AM, Fedor Pchelkin wrote:
> On 24/03/12 08:34AM, Jens Axboe wrote:
>> On 3/12/24 8:23 AM, Fedor Pchelkin wrote:
> 
> [...]
> 
>>> I feel io_uring-SCM related code should be dropped entirely from the
>>> stable branches as the backports already differ greatly between versions
>>> and some parts are still kept, some have been dropped in a non-consistent
>>> order. Though this might contradict with stable kernel rules or be
>>> inappropriate for some other reason.
>>
>> Looks fine to me, and I agree, it makes much more sense to drop it all
>> from 5.10/5.15-stable as well to keep them in sync with upstream. And I
>> think this is fine for stable, dropping code is always a good thing.
>>
> 
> Alright, got it. So that would require dropping it from all of the
> supported 5.4, 6.1, 6.6, 6.7, too.
> 
> Would it be okay if I'll send this as a series?

Yeah I think so, keeping the code more in sync is always a good thing
when it comes to stable. Just make sure you mark the backport commits
with the appropriate upstream shas. Thanks!

-- 
Jens Axboe