linux-kernel - Re: [PATCH v7] dt-bindings: imx-pata: Convert to dtschema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <045ae9cf-104d-472e-94f0-ea7cd5298214@linaro.org>
Date: Tue, 12 Mar 2024 17:25:45 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Animesh Agarwal <animeshagarwal28@...il.com>
Cc: Damien Le Moal <dlemoal@...nel.org>, Rob Herring <robh+dt@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Conor Dooley <conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
 Sascha Hauer <s.hauer@...gutronix.de>,
 Pengutronix Kernel Team <kernel@...gutronix.de>,
 Fabio Estevam <festevam@...il.com>, NXP Linux Team <linux-imx@....com>,
 linux-ide@...r.kernel.org, devicetree@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v7] dt-bindings: imx-pata: Convert to dtschema

On 11/03/2024 15:04, Animesh Agarwal wrote:
> Convert the imx-pata bindings to DT schema.
> Add missing fsl,imx31-pata and
> fsl,imx51-pata compatibles during conversion,
> because they are already being used in existing DTS.

Thank you for improving the commit msg. It looks a bit oddly wrapped. In
the future, please wrap commit message according to Linux coding style /
submission process (neither too early nor over the limit):
https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597

No need to resend just for this... but...
> 
> Signed-off-by: Animesh Agarwal <animeshagarwal28@...il.com>
> 
> ---
> Changes in v7:
> - removed blank space at the end of file.
> 

> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    pata: pata@...e0000 {
> +        compatible = "fsl,imx51-pata","fsl,imx27-pata";

Oh my... missing space after coma, but more important: what is happening
here? The space was here before in previous versions, so you removed it!
At least till v4 it was correct and bam - now it is not. Why? It's the
same confusing as new line appearing suddenly in v6.

It looks like between each revisions of patchset some random changes
appear in your code. How is it possible? Don't you work with Git? You
change file, git add -p and git commit --amend. Why unrelated changes
keep happening?

While the actual space is a nitpick, it points to the fact that your
patch experiences some changes in an unexpected way and we cannot trust
that you did only what you claim in changelog.

Best regards,
Krzysztof