linux-kernel - Re: [PATCH v7] dt-bindings: imx-pata: Convert to dtschema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAE3Oz83x54L9j0TOJmM1C8QGO8Ed=ZY107a0eSL2dO7dXOKfRg@mail.gmail.com>
Date: Tue, 12 Mar 2024 22:19:42 +0530
From: Animesh Agarwal <animeshagarwal28@...il.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc: Damien Le Moal <dlemoal@...nel.org>, Rob Herring <robh+dt@...nel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, Conor Dooley <conor+dt@...nel.org>, 
	Shawn Guo <shawnguo@...nel.org>, Sascha Hauer <s.hauer@...gutronix.de>, 
	Pengutronix Kernel Team <kernel@...gutronix.de>, Fabio Estevam <festevam@...il.com>, 
	NXP Linux Team <linux-imx@....com>, linux-ide@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v7] dt-bindings: imx-pata: Convert to dtschema

On Tue, Mar 12, 2024 at 9:55 PM Krzysztof Kozlowski
<krzysztof.kozlowski@...aro.org> wrote:
> Thank you for improving the commit msg. It looks a bit oddly wrapped. In
> the future, please wrap commit message according to Linux coding style /
> submission process (neither too early nor over the limit):
> https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597

I was just trying to get the lines wrapped within 75 characters
without making it harder to read. I'll follow getting line wrapped at
75 columns more strictly now. Thanks for pointing it out.

> Oh my... missing space after coma, but more important: what is happening
> here? The space was here before in previous versions, so you removed it!
> At least till v4 it was correct and bam - now it is not. Why? It's the
> same confusing as new line appearing suddenly in v6.
>
> It looks like between each revisions of patchset some random changes
> appear in your code. How is it possible? Don't you work with Git? You
> change file, git add -p and git commit --amend. Why unrelated changes
> keep happening?
>
> While the actual space is a nitpick, it points to the fact that your
> patch experiences some changes in an unexpected way and we cannot trust
> that you did only what you claim in changelog.

As you pointed out I indeed made a mistake at v5 by removing the space
and adding a line at the end. I removed the line in v7 and didn't add
the space back. I acknowledge my mistake and will be more careful.

Warm regards,
Animesh