linux-kernel - Re: [PATCH v2] staging: bcm2835-audio: add terminating new line to Kconifg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAE8KmOxEyCHbCt=7PZi_xAnCdc2H3mFYYxBJ9YAq6imGmH6aJw@mail.gmail.com>
Date: Wed, 13 Mar 2024 22:19:29 +0530
From: Prasad Pandit <ppandit@...hat.com>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: florian.fainelli@...adcom.com, bcm-kernel-feedback-list@...adcom.com, 
	linux-arm-kernel@...ts.infradead.org, gregkh@...uxfoundation.org, 
	rjui@...adcom.com, sbranden@...adcom.com, linux-staging@...ts.linux.dev, 
	linux-rpi-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, 
	Prasad Pandit <pjp@...oraproject.org>
Subject: Re: [PATCH v2] staging: bcm2835-audio: add terminating new line to Kconifg

Hello Dan,

On Wed, 13 Mar 2024 at 17:24, Dan Carpenter <dan.carpenter@...aro.org> wrote:
> I wasn't able to get it to enable the CONFIG_NO_HZ_FULL.

* CONFIG_ prefix is not required.

> ~/config-kernel/configk -e NO_HZ_FULL  -c .config  .

* This command works. It writes informatory logs to stderr. It helps
to redirect stderr to a log file.
Enable option:
  NO_HZ_FULL
    NO_HZ_COMMON
      TICK_ONESHOT
    RCU_NOCB_CPU
    VIRT_CPU_ACCOUNTING_GEN
      VIRT_CPU_ACCOUNTING
      CONTEXT_TRACKING_USER
        CONTEXT_TRACKING
    IRQ_WORK
    CPU_ISOLATION

* To see enable/disable/toggle options in action, a command below
(without -c .config) could make it easier perhaps.

    $ ~/config-kernel/configk -e NO_HZ_FULL=[y/n/m]  <linux-directory>
 | less -r

> I'm going Ack your patch because adding a newline is the correct thing
> but you should probably also change configk to handle that.

* ie. Handle files not terminating with a newline? There are not as
many such files. Besides I agree having files terminate with a newline
is good. It makes all lines/records of consistent format, otherwise
the very last line/record becomes a special case.

Thank you.
---
  - Prasad