linux-kernel - Re: [PATCH v2] staging: bcm2835-audio: add terminating new line to Kconifg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3fcb3702-5af2-4b9f-a362-4f08ee626b14@moroto.mountain>
Date: Wed, 13 Mar 2024 14:53:47 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Prasad Pandit <ppandit@...hat.com>
Cc: florian.fainelli@...adcom.com, bcm-kernel-feedback-list@...adcom.com,
	linux-arm-kernel@...ts.infradead.org, gregkh@...uxfoundation.org,
	rjui@...adcom.com, sbranden@...adcom.com,
	linux-staging@...ts.linux.dev, linux-rpi-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org, Prasad Pandit <pjp@...oraproject.org>
Subject: Re: [PATCH v2] staging: bcm2835-audio: add terminating new line to
 Kconifg

On Wed, Mar 13, 2024 at 04:44:09PM +0530, Prasad Pandit wrote:
> Hi,
> 
> On Wed, 13 Mar 2024 at 15:47, Dan Carpenter <dan.carpenter@...aro.org> wrote:
> > Why does this make a difference?  Is it just because it's annoying to
> > cat a file that doesn't have a newline at the end?
> 
> * It's not just #PetPeeve. I'm trying to fix parsing errors reported
> by the config-kernel tool[1], so that users can view all CONFIG
> attributes without errors.

Huh.  The seems like a very nice program.  I've wanted a way to enable
config items from command line for a long time.  I wasn't able to get it
enable the CONFIG_NO_HZ_FULL.

~/config-kernel/configk -e NO_HZ_FULL  -c .config  .

I'm going Ack your patch because adding a newline is the correct thing
but you should probably also change configk to handle that.

> 
> > I checked, and it's not a checkpatch warning.  Perhaps it should be though.
> > KTODO: make checkpatch.pl warn about files that don't end in a newline
> 
> * I'll take a look at checkpatch.pl.

It's not required.  The KTODO is just a shared todo list and anyone can
add stuff to todo list or do it, but it's not mandatory at all.

regards,
dan carpenter