linux-kernel - Re: [PATCH v3 2/2] rust: sync: add `Arc::into_unique_or

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZfHejEkGKPPHPx05@boqun-archlinux>
Date: Wed, 13 Mar 2024 10:12:44 -0700
From: Boqun Feng <boqun.feng@...il.com>
To: Alice Ryhl <aliceryhl@...gle.com>
Cc: a.hindborg@...sung.com, alex.gaynor@...il.com, benno.lossin@...ton.me,
	bjorn3_gh@...tonmail.com, gary@...yguo.net,
	linux-kernel@...r.kernel.org, ojeda@...nel.org,
	rust-for-linux@...r.kernel.org, wedsonaf@...il.com
Subject: Re: [PATCH v3 2/2] rust: sync: add `Arc::into_unique_or_drop`

On Wed, Mar 13, 2024 at 09:50:59AM +0000, Alice Ryhl wrote:
> Boqun Feng <boqun.feng@...il.com> writes:
> > The code looks good, and FWIW, I added the Examples section for the
> > function since I at least need something to run when queuing it to
> > rust-dev branch ;-) And I think it's overall good to have examples for
> > every `pub` function. If there is a next version (which is unlikely),
> > feel free to fold it. I can also send it alone once Miguel put your
> > patches into the rust-next branch.
> 
> Thanks! If you have reviewed it, could I have your Reviewed-by tag?
> 

Done.

> > From 7d26d1177a2788ba96c607fd9dc45baf469fb439 Mon Sep 17 00:00:00 2001
> > From: Boqun Feng <boqun.feng@...il.com>
> > Date: Tue, 12 Mar 2024 10:03:39 -0700
> > Subject: [PATCH] kernel: sync: Add "Examples" section for
> >  Arc::into_unique_or_drop()
> > 
> > These examples provide better documentation and can serve as unit tests
> > as well, so add them.
> > 
> > Signed-off-by: Boqun Feng <boqun.feng@...il.com>
> 
> Reviewed-by: Alice Ryhl <aliceryhl@...gle.com>
> 

Thanks! I will add it.

Regards,
Boqun

> Alice