linux-kernel - Re: [PATCH 04/10] perf: Rename PERF_PMU_CAP_NO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202403131930.sz1VjXDw-lkp@intel.com>
Date: Wed, 13 Mar 2024 20:05:54 +0800
From: kernel test robot <lkp@...el.com>
To: Robin Murphy <robin.murphy@....com>,
	Peter Zijlstra <peterz@...radead.org>,
	Ingo Molnar <mingo@...hat.com>,
	Arnaldo Carvalho de Melo <acme@...nel.org>,
	Namhyung Kim <namhyung@...nel.org>,
	Mark Rutland <mark.rutland@....com>, Will Deacon <will@...nel.org>
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
	Jiri Olsa <jolsa@...nel.org>, Ian Rogers <irogers@...gle.com>,
	Adrian Hunter <adrian.hunter@...el.com>,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	x86@...nel.org, linux-perf-users@...r.kernel.org,
	jialong.yang@...ngroup.cn
Subject: Re: [PATCH 04/10] perf: Rename PERF_PMU_CAP_NO_INTERRUPT

Hi Robin,

kernel test robot noticed the following build errors:

[auto build test ERROR on perf-tools-next/perf-tools-next]
[also build test ERROR on perf-tools/perf-tools linus/master v6.8 next-20240313]
[cannot apply to acme/perf/core tip/perf/core]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Robin-Murphy/perf-alibaba_uncore_drw-Use-correct-CPU-affinity/20240313-013915
base:   https://git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git perf-tools-next
patch link:    https://lore.kernel.org/r/0999a39f0a068979dbcc6119380f63d706101b4f.1710257512.git.robin.murphy%40arm.com
patch subject: [PATCH 04/10] perf: Rename PERF_PMU_CAP_NO_INTERRUPT
config: x86_64-allnoconfig (https://download.01.org/0day-ci/archive/20240313/202403131930.sz1VjXDw-lkp@intel.com/config)
compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240313/202403131930.sz1VjXDw-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202403131930.sz1VjXDw-lkp@intel.com/

All errors (new ones prefixed by >>):

>> arch/x86/events/core.c:1815:46: error: expected ';' after expression
    1815 |         pmu.capabilities |= PERF_PMU_CAP_NO_SAMPLING
         |                                                     ^
         |                                                     ;
   1 error generated.


vim +1815 arch/x86/events/core.c

  1799	
  1800	static void __init pmu_check_apic(void)
  1801	{
  1802		if (boot_cpu_has(X86_FEATURE_APIC))
  1803			return;
  1804	
  1805		x86_pmu.apic = 0;
  1806		pr_info("no APIC, boot with the \"lapic\" boot parameter to force-enable it.\n");
  1807		pr_info("no hardware sampling interrupt available.\n");
  1808	
  1809		/*
  1810		 * If we have a PMU initialized but no APIC
  1811		 * interrupts, we cannot sample hardware
  1812		 * events (user-space has to fall back and
  1813		 * sample via a hrtimer based software event):
  1814		 */
> 1815		pmu.capabilities |= PERF_PMU_CAP_NO_SAMPLING
  1816	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki