linux-kernel - Re: [PATCH 07/10] perf: Define common uncore capabilities

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b94175cd-3128-4c94-b888-32ccd0164e9c@arm.com>
Date: Wed, 13 Mar 2024 12:24:31 +0000
From: Robin Murphy <robin.murphy@....com>
To: James Clark <james.clark@....com>
Cc: Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
 Jiri Olsa <jolsa@...nel.org>, Ian Rogers <irogers@...gle.com>,
 Adrian Hunter <adrian.hunter@...el.com>, linux-kernel@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, x86@...nel.org,
 linux-perf-users@...r.kernel.org, jialong.yang@...ngroup.cn,
 Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>,
 Arnaldo Carvalho de Melo <acme@...nel.org>,
 Namhyung Kim <namhyung@...nel.org>, Mark Rutland <mark.rutland@....com>,
 Will Deacon <will@...nel.org>
Subject: Re: [PATCH 07/10] perf: Define common uncore capabilities

On 2024-03-13 11:23 am, James Clark wrote:
> 
> 
> On 12/03/2024 17:34, Robin Murphy wrote:
>> Nearly all uncore/system PMUs share a common set of capbilities,
>> so let's wrap those up in a single macro for ease of use.
>>
>> Signed-off-by: Robin Murphy <robin.murphy@....com>
>> ---
>>   include/linux/perf_event.h | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h
>> index b1fd832ed8bf..5d5db122005b 100644
>> --- a/include/linux/perf_event.h
>> +++ b/include/linux/perf_event.h
>> @@ -293,6 +293,9 @@ struct perf_event_pmu_context;
>>   #define PERF_PMU_CAP_EXTENDED_HW_TYPE		0x0100
>>   #define PERF_PMU_CAP_NO_COMMON_EVENTS		0x0200
>>   
>> +#define PERF_PMU_UNCORE_CAPS \
>> +(PERF_PMU_CAP_NO_SAMPLING| PERF_PMU_CAP_NO_EXCLUDE | PERF_PMU_CAP_NO_COMMON_EVENTS)
>> +
> 
> The most minor of nits: missing space before |. There is another one in
> another commit that triggers checkpatch but that line gets deleted anyway.

Bleh, thanks for the catch. And it seems that wasn't the only thing I 
inexplicably managed to mess up in the rename patch either... All fixed 
locally now.

Cheers,
Robin.

> 
>>   struct perf_output_handle;
>>   
>>   #define PMU_NULL_DEV	((void *)(~0UL))