lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240313153236.GA2931742@dev-arch.thelio-3990X>
Date: Wed, 13 Mar 2024 08:32:36 -0700
From: Nathan Chancellor <nathan@...nel.org>
To: Randy Dunlap <rdunlap@...radead.org>
Cc: linux-kernel@...r.kernel.org, kernel test robot <lkp@...el.com>,
	Michael Büsch <m@...s.ch>,
	linux-wireless@...r.kernel.org, Kalle Valo <kvalo@...nel.org>,
	Johannes Berg <johannes@...solutions.net>, llvm@...ts.linux.dev
Subject: Re: [PATCH] ssb: use "break" on default case to prevent warning

On Tue, Mar 12, 2024 at 05:13:03PM -0700, Randy Dunlap wrote:
> Having an empty default: case in a switch statement causes a warning
> (when using Clang; I don't see the warning when using gcc),
> so add a "break;" to the default case to prevent the warning:
> 
> drivers/ssb/main.c:1149:2: warning: label at end of compound statement is a C2x extension [-Wc2x-extensions]

It is a hard error with earlier versions of clang as well:

  drivers/ssb/main.c:1148:10: error: label at end of compound statement: expected statement
          default:
                  ^
                   ;
  1 error generated.

> Fixes: e27b02e23a70 ("ssb: drop use of non-existing CONFIG_SSB_DEBUG symbol")
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202403130717.TWm17FiD-lkp@intel.com/
> Cc: Michael Büsch <m@...s.ch>
> Cc: linux-wireless@...r.kernel.org
> Cc: Kalle Valo <kvalo@...nel.org>
> Cc: Johannes Berg <johannes@...solutions.net>
> Cc: llvm@...ts.linux.dev

Thanks for the quick fix!

Reviewed-by: Nathan Chancellor <nathan@...nel.org>

> ---
>  drivers/ssb/main.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff -- a/drivers/ssb/main.c b/drivers/ssb/main.c
> --- a/drivers/ssb/main.c
> +++ b/drivers/ssb/main.c
> @@ -1144,6 +1144,7 @@ u32 ssb_dma_translation(struct ssb_devic
>  				return SSB_PCI_DMA;
>  		}
>  	default:
> +		break;
>  	}
>  	return 0;
>  }
> 

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ