linux-kernel - Re: [PATCH] ssb: use "break" on default case to prevent warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Thu, 14 Mar 2024 08:56:38 +0000 (UTC)
From: Kalle Valo <kvalo@...nel.org>
To: Randy Dunlap <rdunlap@...radead.org>
Cc: linux-kernel@...r.kernel.org, Randy Dunlap <rdunlap@...radead.org>,
 kernel test robot <lkp@...el.com>,
 Michael Büsch <m@...s.ch>, linux-wireless@...r.kernel.org,
 Johannes Berg <johannes@...solutions.net>, llvm@...ts.linux.dev
Subject: Re: [PATCH] ssb: use "break" on default case to prevent warning

Randy Dunlap <rdunlap@...radead.org> wrote:

> Having an empty default: case in a switch statement causes a warning
> (when using Clang; I don't see the warning when using gcc),
> so add a "break;" to the default case to prevent the warning:
> 
> drivers/ssb/main.c:1149:2: warning: label at end of compound statement is a C2x extension [-Wc2x-extensions]
> 
> Fixes: e27b02e23a70 ("ssb: drop use of non-existing CONFIG_SSB_DEBUG symbol")
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202403130717.TWm17FiD-lkp@intel.com/
> Cc: Michael Büsch <m@...s.ch>
> Cc: linux-wireless@...r.kernel.org
> Cc: Kalle Valo <kvalo@...nel.org>
> Cc: Johannes Berg <johannes@...solutions.net>
> Cc: llvm@...ts.linux.dev
> Acked-by: Michael Büsch <m@...s.ch>
> Reviewed-by: Nathan Chancellor <nathan@...nel.org>

Patch applied to wireless-next.git, thanks.

6c700b35a534 ssb: use "break" on default case to prevent warning

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20240313001305.18820-1-rdunlap@infradead.org/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches