linux-kernel - Re: [PATCH v7 1/2] spi: Unify error codes by replacing -ENOTSUPP with -EOPNOTSUPP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <CZSQTVDX6QR1.1K5UGJUNPLM0S@walle.cc>
Date: Wed, 13 Mar 2024 16:56:00 +0100
From: "Michael Walle" <michael@...le.cc>
To: "AceLan Kao" <acelan.kao@...onical.com>, "Tudor Ambarus"
 <tudor.ambarus@...aro.org>, "Pratyush Yadav" <pratyush@...nel.org>, "Miquel
 Raynal" <miquel.raynal@...tlin.com>, "Richard Weinberger" <richard@....at>,
 "Vignesh Raghavendra" <vigneshr@...com>, "Mika Westerberg"
 <mika.westerberg@...ux.intel.com>, "Dhruva Gole" <d-gole@...com>,
 <linux-mtd@...ts.infradead.org>, "Mark Brown" <broonie@...nel.org>, "Kamal
 Dasu" <kamal.dasu@...adcom.com>, Jonathan Neuschäfer
 <j.neuschaefer@....net>, "Mario Kicherer" <dev@...herer.org>, "Chuanhong
 Guo" <gch981213@...il.com>, <linux-spi@...r.kernel.org>,
 <linux-kernel@...r.kernel.org>
Cc: "Florian Fainelli" <florian.fainelli@...adcom.com>
Subject: Re: [PATCH v7 1/2] spi: Unify error codes by replacing -ENOTSUPP
 with -EOPNOTSUPP

Hi,

I just had a quick look to see where Florians breakage could come
from and just noticed this:

> diff --git a/drivers/mtd/nand/spi/core.c b/drivers/mtd/nand/spi/core.c
> index 849ccfedbc72..e0b6715e5dfe 100644
> --- a/drivers/mtd/nand/spi/core.c
> +++ b/drivers/mtd/nand/spi/core.c
> @@ -974,7 +974,7 @@ static int spinand_manufacturer_match(struct spinand_device *spinand,
>  		spinand->manufacturer = manufacturer;
>  		return 0;
>  	}
> -	return -ENOTSUPP;
> +	return -EOPNOTSUPP;
>  }
>  
>  static int spinand_id_detect(struct spinand_device *spinand)

This seems to be random as no other spi-nand ENOTSUPP was converted
but just this. Is there a reason for this, AceLan?

-michael

Download attachment "signature.asc" of type "application/pgp-signature" (253 bytes)