linux-kernel - Re: [PATCH v2 01/15] dmaengine: bcm2835: Fix several spellos

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <886b0def-7884-4780-8b7f-e29bf3d9ce7d@broadcom.com>
Date: Wed, 13 Mar 2024 09:38:41 -0700
From: Florian Fainelli <florian.fainelli@...adcom.com>
To: Andrea della Porta <andrea.porta@...e.com>, Vinod Koul
 <vkoul@...nel.org>, Rob Herring <robh+dt@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Conor Dooley <conor+dt@...nel.org>, Ray Jui <rjui@...adcom.com>,
 Scott Branden <sbranden@...adcom.com>,
 Broadcom internal kernel review list
 <bcm-kernel-feedback-list@...adcom.com>, Saenz Julienne <nsaenz@...nel.org>,
 dmaengine@...r.kernel.org, devicetree@...r.kernel.org,
 linux-rpi-kernel@...ts.infradead.org, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org, dave.stevenson@...pberrypi.com,
 Phil Elwell <phil@...pberrypi.org>, Maxime Ripard <maxime@...no.tech>,
 Stefan Wahren <stefan.wahren@...e.com>, Dom Cobley <popcornmix@...il.com>
Subject: Re: [PATCH v2 01/15] dmaengine: bcm2835: Fix several spellos

On 3/13/24 08:26, Andrea della Porta wrote:
> On 08:00 Wed 13 Mar     , Florian Fainelli wrote:
>>
>>
>> On 3/13/2024 7:08 AM, Andrea della Porta wrote:
>>> Fixed Codespell reported warnings about spelling and coding convention
>>> violations, among which there are also a couple potential operator
>>> precedence issue in macroes.

and s/macroes/macros/

>>>
>>> Signed-off-by: Andrea della Porta <andrea.porta@...e.com>
>>
>> There are no spelling errors being fixed in this commit, this is purely
>> stylistic and conforming to the Linux coding style guidelines.
> 
> -	/* detect a size missmatch */
> -	if (buf_len && (d->size != buf_len))
> +	/* detect a size mismatch */
> +	if (buf_len && d->size != buf_len)
> 
> Isn't 'missmatch' a spelling error? Maybe I can drop the word 'several', since it's
> indeed only one...

Can we agree this was easy to miss when 99% of the changes are 
stylistic? The summary is that the commit subject and the message are 
not describing what this patch is about.
-- 
Florian


Download attachment "smime.p7s" of type "application/pkcs7-signature" (4221 bytes)