linux-kernel - [PATCH v3 2/2] rtc: rtc-pm8xxx: Correct the PM8xxx_RTC_ALARM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240314033449.10872-1-quic_jianbinz@quicinc.com>
Date: Thu, 14 Mar 2024 11:34:49 +0800
From: jianbinz <quic_jianbinz@...cinc.com>
To: <alexandre.belloni@...tlin.com>, <a.zummo@...ertech.it>
CC: jianbinz <quic_jianbinz@...cinc.com>, <linux-rtc@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: [PATCH v3 2/2] rtc: rtc-pm8xxx: Correct the PM8xxx_RTC_ALARM_CLEAR vaule in trigger

Change in v3:
*Correct the vaule that writed into the PM8xxx_RTC_ALARM_CLEAR to 1.

Change in v2:
*Switch to using regmap_update_bits() instead of open coding
read-modify-write accesses.
Link to v2: https://lore.kernel.org/lkml/20230202155448.6715-4-johan+linaro@kernel.org/

Signed-off-by: jianbinz <quic_jianbinz@...cinc.com>
---
 drivers/rtc/rtc-pm8xxx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/rtc/rtc-pm8xxx.c b/drivers/rtc/rtc-pm8xxx.c
index 1b5a96924e57..8a9be78d0b0b 100644
--- a/drivers/rtc/rtc-pm8xxx.c
+++ b/drivers/rtc/rtc-pm8xxx.c
@@ -391,7 +391,7 @@ static irqreturn_t pm8xxx_alarm_trigger(int irq, void *dev_id)
 
 	/* Clear alarm status */
 	rc = regmap_update_bits(rtc_dd->regmap, regs->alarm_ctrl2,
-				PM8xxx_RTC_ALARM_CLEAR, 0);
+				PM8xxx_RTC_ALARM_CLEAR, 1);
 	if (rc)
 		return IRQ_NONE;
 
-- 
2.17.1