linux-kernel - Re: [PATCH v3 2/2] rtc: rtc-pm8xxx: Correct the PM8xxx_RTC_ALARM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240319191216.GB3796206@hu-bjorande-lv.qualcomm.com>
Date: Tue, 19 Mar 2024 12:12:16 -0700
From: Bjorn Andersson <quic_bjorande@...cinc.com>
To: jianbinz <quic_jianbinz@...cinc.com>
CC: <alexandre.belloni@...tlin.com>, <a.zummo@...ertech.it>,
        <linux-rtc@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 2/2] rtc: rtc-pm8xxx: Correct the
 PM8xxx_RTC_ALARM_CLEAR vaule in trigger

On Thu, Mar 14, 2024 at 11:34:49AM +0800, jianbinz wrote:
> Change in v3:
> *Correct the vaule that writed into the PM8xxx_RTC_ALARM_CLEAR to 1.
> 
> Change in v2:
> *Switch to using regmap_update_bits() instead of open coding
> read-modify-write accesses.
> Link to v2: https://lore.kernel.org/lkml/20230202155448.6715-4-johan+linaro@kernel.org/
> 
> Signed-off-by: jianbinz <quic_jianbinz@...cinc.com>

Same feedback as on patch 1/2, but on this one you're also completely
missing a commit message clearly describing the problem that your change
is solving.

Regards,
Bjorn

> ---
>  drivers/rtc/rtc-pm8xxx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/rtc/rtc-pm8xxx.c b/drivers/rtc/rtc-pm8xxx.c
> index 1b5a96924e57..8a9be78d0b0b 100644
> --- a/drivers/rtc/rtc-pm8xxx.c
> +++ b/drivers/rtc/rtc-pm8xxx.c
> @@ -391,7 +391,7 @@ static irqreturn_t pm8xxx_alarm_trigger(int irq, void *dev_id)
>  
>  	/* Clear alarm status */
>  	rc = regmap_update_bits(rtc_dd->regmap, regs->alarm_ctrl2,
> -				PM8xxx_RTC_ALARM_CLEAR, 0);
> +				PM8xxx_RTC_ALARM_CLEAR, 1);
>  	if (rc)
>  		return IRQ_NONE;
>  
> -- 
> 2.17.1
>