linux-kernel - Re: [PATCH 2/2] docs: iio: new docs for ad7944 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date: Thu, 14 Mar 2024 11:01:25 -0500
From: David Lechner <dlechner@...libre.com>
To: Jonathan Cameron <jic23@...nel.org>
Cc: Michael Hennerich <michael.hennerich@...log.com>, Nuno Sá <nuno.sa@...log.com>, 
	Jonathan Corbet <corbet@....net>, linux-doc@...r.kernel.org, linux-iio@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] docs: iio: new docs for ad7944 driver

I missed the reply-all on my last reply, so adding back this lists for
the record.

On Thu, Mar 14, 2024 at 10:57 AM Jonathan Cameron <jic23@...nel.org> wrote:
>
> On Thu, 14 Mar 2024 10:52:57 -0500
> David Lechner <dlechner@...libre.com> wrote:
>
> > On Wed, Mar 13, 2024 at 3:28 PM David Lechner <dlechner@...libre.com> wrote:
> >
> > ...
> >
> > > +AD7944 and AD7985 are pseudo-differential ADCs and have the following attributes:
> > > +
> > > ++---------------------------------------+--------------------------------------------------------------+
> > > +| Attribute                             | Description                                                  |
> > > ++=======================================+==============================================================+
> > > +| ``in_voltage0_raw``                   | Raw ADC voltage value (*IN+* referenced to ground sense).    |
> > > ++---------------------------------------+--------------------------------------------------------------+
> > > +| ``in_voltage0_scale``                 | Scale factor to convert raw value to mV.                     |
> > > ++---------------------------------------+--------------------------------------------------------------+
> > > +
> >
> > A colleague pointed out that it is perhaps a bit unusual to have
> > per-channel scaling since the scale is determined by a single
> > reference voltage. I guess it is OK here since there is only one
> > channel. But the driver hasn't hit mainline yet, so we could change
> > that if you think it is better to have a "shared" `in_voltage_scale`.
> Lots of devices have per channel scaling (amplifiers on the front end) but
> on a single channel device, it could be shared or per channel without
> it making any practical difference.
>
> It's unusual, but not wrong, so I'm not that fussed either way.
>
> >
> > ...
> >
> > > +
> > > +Show voltage input channel values:
> > > +
> > > +.. code-block:: console
> > > +
> > > +    root:/sys/bus/iio/devices/iio:device0# cat voltage0-voltage1_raw
> > > +    -101976
> > > +    root:/sys/bus/iio/devices/iio:device0# cat voltage0-voltage1_scale
> > > +    0.038146972
> > > +
> >
> > Typo here. Missing `in_` on the attribute name.
>