linux-kernel - Re: [PATCH] arm64: dts: rockchip: add &gmac2phy in rk3328-rock64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <96a53f8560b3563328eaf7b9d6f63d87@manjaro.org>
Date: Fri, 15 Mar 2024 09:56:44 +0100
From: Dragan Simic <dsimic@...jaro.org>
To: Himanshu Bhavani <himanshu.bhavani@...iconsignals.io>
Cc: robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org, Conor Dooley
 <conor+dt@...nel.org>, Heiko Stuebner <heiko@...ech.de>, Lorenz Brun
 <lorenz@...n.one>, devicetree@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-rockchip@...ts.infradead.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: rockchip: add &gmac2phy in rk3328-rock64

Hello Himanshu,

On 2024-03-15 09:40, Himanshu Bhavani wrote:
> Add '&gmac2phy' node to enable ethernet1 on rk3328-rock64
> 
> Signed-off-by: Himanshu Bhavani <himanshu.bhavani@...iconsignals.io>
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
> b/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
> index 229fe9da9c2d..cb919367db54 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
> @@ -12,6 +12,7 @@ / {
> 
>  	aliases {
>  		ethernet0 = &gmac2io;
> +		ethernet1 = &gmac2phy;
>  		mmc0 = &sdmmc;
>  		mmc1 = &emmc;
>  	};
> @@ -392,3 +393,7 @@ &vop {
>  &vop_mmu {
>  	status = "okay";
>  };
> +
> +&gmac2phy {
> +	staus = "okay";
> +};

Unfortunately, this isn't an acceptable change to the Rock64 dts file.
Yes, there's the second built-in Ethernet interface in the RK3328 SoC,
but the Rock64 layout doesn't expose it as a separate physical network
interface, i.e. it isn't available as a port.

Such a change would be fine to be applied to the dts by hand, by someone
who actually adds a second physical network port to their Rock64.