linux-kernel - Re: [PATCH] mtd: rawnand: hynix: fixed typo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240315122314.10c88c2e@xps-13>
Date: Fri, 15 Mar 2024 12:23:14 +0100
From: Miquel Raynal <miquel.raynal@...tlin.com>
To: Maxim Korotkov <korotkov.maxim.s@...il.com>
Cc: Boris Brezillon <bbrezillon@...nel.org>, Richard Weinberger
 <richard@....at>, Vignesh Raghavendra <vigneshr@...com>, Hector Palacios
 <hector.palacios@...i.com>, linux-mtd@...ts.infradead.org,
 linux-kernel@...r.kernel.org, lvc-project@...uxtesting.org
Subject: Re: [PATCH] mtd: rawnand: hynix: fixed typo

Hi Maxim,

korotkov.maxim.s@...il.com wrote on Wed, 13 Mar 2024 13:27:20 +0300:

> The function hynix_nand_rr_init() should probably return an error code.
> Judging by the usage, it seems that the return code is passed up 
> the call stack.
> Right now, it always returns 0 and the function hynix_nand_cleanup()
> in hynix_nand_init() has never been called.

Isn't it done like that on purpose? Read-retry is not a mandatory
feature.

> Found by RASU JSC and Linux Verification Center (linuxtesting.org)
> 
> Fixes: 626994e07480 ("mtd: nand: hynix: Add read-retry support for 1x nm MLC NANDs")
> 
> Signed-off-by: Maxim Korotkov <korotkov.maxim.s@...il.com>
> ---

Thanks,
Miquèl