linux-kernel - Re: [PATCH] mtd: rawnand: hynix: fixed typo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240315131412.488167c1@xps-13>
Date: Fri, 15 Mar 2024 13:14:12 +0100
From: Miquel Raynal <miquel.raynal@...tlin.com>
To: Maxim Korotkov <korotkov.maxim.s@...il.com>
Cc: Boris Brezillon <bbrezillon@...nel.org>, Richard Weinberger
 <richard@....at>, Vignesh Raghavendra <vigneshr@...com>, Hector Palacios
 <hector.palacios@...i.com>, linux-mtd@...ts.infradead.org,
 linux-kernel@...r.kernel.org, lvc-project@...uxtesting.org
Subject: Re: [PATCH] mtd: rawnand: hynix: fixed typo

Hi Maxim,

korotkov.maxim.s@...il.com wrote on Fri, 15 Mar 2024 14:45:47 +0300:

> Hi,
> 
> On 15.03.2024 14:23, Miquel Raynal wrote:
> > Isn't it done like that on purpose? Read-retry is not a mandatory
> > feature.  
> 
> Works it as designed? I'm not sure about it.
> I wouldn't rule it out, but it's a little weird that the hynix_nand_rr_init() function
> is used as if it can return an error but never returns.
> 
> Probably  checking  of value returned from hynix_nand_rr_init()
> should be removed in hynix_nand_init()

It is indeed confusing. I'll take it.

Thanks,
Miquèl