linux-kernel - Re: [PATCH V2 1/3] tools/tracing: Use tools/build makefiles on latency-collector

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZfRg8CB5xXL2Y-zC@x1>
Date: Fri, 15 Mar 2024 11:53:36 -0300
From: Arnaldo Carvalho de Melo <acme@...nel.org>
To: Daniel Bristot de Oliveira <bristot@...nel.org>
Cc: Linus Torvalds <torvalds@...ux-foundation.org>,
	Steven Rostedt <rostedt@...dmis.org>,
	Arnaldo Carvalho de Melo <acme@...hat.com>,
	Josh Poimboeuf <jpoimboe@...nel.org>,
	John Kacur <jkacur@...hat.com>, Namhyung Kim <namhyung@...nel.org>,
	Jiri Olsa <jolsa@...nel.org>, linux-perf-users@...r.kernel.org,
	linux-trace-kernel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2 1/3] tools/tracing: Use tools/build makefiles on
 latency-collector

On Fri, Mar 15, 2024 at 03:48:58PM +0100, Daniel Bristot de Oliveira wrote:
> On 3/15/24 15:24, Daniel Bristot de Oliveira wrote:
> > Use tools/build/ makefiles to build latency-collector, inheriting
> > the benefits of it. For example: Before this patch, a missing
> > tracefs/traceevents headers will result in fail like this:
> > 
> > -------------------------------- %< -------------------------------
> 
> Oops, b4 is interpreting these ------ as the '---' separator, and is truncating
> the message. I will fix this in a v3.
> 
> sorry.

Yeah, that confuses scripts, that separator.

But overall I tested various versions of your patches and they look ok.

That tools/build/ was done for other tools to use and so far some tools/
living projects use it: tools/objtool, tools/lib/subcmd, etc.

I just did a:

git grep tools\/build

And there is quite a few more I didn't realize have been using bits and
pieces, good.

- Arnaldo