linux-kernel - Re: [RFC PATCH] xfs_io: add linux madvise advice codes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZfddKAS2GUOG41wb@infradead.org>
Date: Sun, 17 Mar 2024 14:14:16 -0700
From: Christoph Hellwig <hch@...radead.org>
To: "Darrick J. Wong" <djwong@...nel.org>
Cc: David Hildenbrand <david@...hat.com>, linux-kernel@...r.kernel.org,
	linux-mm@...ck.org, fstests <fstests@...r.kernel.org>,
	xfs <linux-xfs@...r.kernel.org>
Subject: Re: [RFC PATCH] xfs_io: add linux madvise advice codes

> +#
> +# Check if asm/mman.h can be included
> +#
> +AC_DEFUN([AC_HAVE_KERNEL_MADVISE_FLAGS],
> +  [ AC_MSG_CHECKING([for kernel madvise flags in asm/mman.h ])
> +    AC_COMPILE_IFELSE(
> +    [	AC_LANG_PROGRAM([[
> +#include <asm/mman.h>
> +	]], [[
> +int moo = MADV_COLLAPSE;
> +	]])
> +    ], have_kernel_madvise=yes
> +       AC_MSG_RESULT(yes),
> +       AC_MSG_RESULT(no))
> +    AC_SUBST(have_kernel_madvise)
> +  ])
> +

I don't think we really need this check, as madvise and asm/mman.h
have been around forever.  We can probably also drop most of the
actual flag idefs, probably for everything older than MADV_WIPEONFORK.

The rest looks good to me.