linux-kernel - Re: [PATCH v3] keys: update key quotas in key

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <CZX77XLG67HZ.UAU4NUQO27JP@kernel.org>
Date: Mon, 18 Mar 2024 23:37:19 +0200
From: "Jarkko Sakkinen" <jarkko@...nel.org>
To: "Jarkko Sakkinen" <jarkko@...nel.org>, "Luis Henriques"
 <luis.henriques@...ux.dev>, "David Howells" <dhowells@...hat.com>
Cc: "Eric Biggers" <ebiggers@...nel.org>, <keyrings@...r.kernel.org>,
 <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3] keys: update key quotas in key_put()

On Mon Mar 18, 2024 at 11:14 PM EET, Jarkko Sakkinen wrote:
> On Wed Mar 13, 2024 at 2:37 PM EET, Luis Henriques wrote:
> > Luis Henriques <lhenriques@...e.de> writes:
> >
> > > David Howells <dhowells@...hat.com> writes:
> > >
> > >> Luis Henriques <lhenriques@...e.de> wrote:
> > >>
> > >>> Delaying key quotas update when key's refcount reaches 0 in key_put() has
> > >>> been causing some issues in fscrypt testing, specifically in fstest
> > >>> generic/581.  This commit fixes this test flakiness by dealing with the
> > >>> quotas immediately, and leaving all the other clean-ups to the key garbage
> > >>> collector.
> > >>
> > >> Okay, I'll accept this.
> > >>
> > >
> > > That's awesome, thanks a lot David.  And, as Eric requested, I'll send out
> > > shortly a follow-up fscrypt-specific patch, which will make generic/581
> > > fstest finally pass.
> >
> > Ping.  Looks like this fell through the cracks...?
> >
> > I took a quick look at some git trees ('jarkko' and 'dhowells') but
> > couldn't see this patch anywhere.
> >
> > Cheers,
>
> My bad! I'll pick this up now.

I applied it.

Only for completeness sake I mention that I tuned the 2nd paragraph so
that lines do no exceed 75 characters :-) Otherwise, I did not modify
the commit.

I'll schedule this to a PR after rc1 is out (just to see if there is
something else that needs to be picked before that).

BR, Jarkko