linux-kernel - Re: [PATCH v3 0/8] Clean up libperf cpumap's empty function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zfi0IJV-OKwyDK0r@x1>
Date: Mon, 18 Mar 2024 18:37:36 -0300
From: Arnaldo Carvalho de Melo <acme@...nel.org>
To: Namhyung Kim <namhyung@...nel.org>
Cc: Ian Rogers <irogers@...gle.com>,
	Adrian Hunter <adrian.hunter@...el.com>,
	James Clark <james.clark@....com>,
	Peter Zijlstra <peterz@...radead.org>,
	Ingo Molnar <mingo@...hat.com>, Mark Rutland <mark.rutland@....com>,
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
	Jiri Olsa <jolsa@...nel.org>,
	Suzuki K Poulose <suzuki.poulose@....com>,
	Mike Leach <mike.leach@...aro.org>,
	John Garry <john.g.garry@...cle.com>, Will Deacon <will@...nel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Darren Hart <dvhart@...radead.org>,
	Davidlohr Bueso <dave@...olabs.net>,
	André Almeida <andrealmeid@...lia.com>,
	Kan Liang <kan.liang@...ux.intel.com>,
	K Prateek Nayak <kprateek.nayak@....com>,
	Sean Christopherson <seanjc@...gle.com>,
	Paolo Bonzini <pbonzini@...hat.com>,
	Kajol Jain <kjain@...ux.ibm.com>,
	Athira Rajeev <atrajeev@...ux.vnet.ibm.com>,
	Andrew Jones <ajones@...tanamicro.com>,
	Alexandre Ghiti <alexghiti@...osinc.com>,
	Atish Patra <atishp@...osinc.com>,
	"Steinar H. Gunderson" <sesse@...gle.com>,
	Yang Jihong <yangjihong1@...wei.com>,
	Yang Li <yang.lee@...ux.alibaba.com>,
	Changbin Du <changbin.du@...wei.com>,
	Sandipan Das <sandipan.das@....com>,
	Ravi Bangoria <ravi.bangoria@....com>,
	Paran Lee <p4ranlee@...il.com>,
	Nick Desaulniers <ndesaulniers@...gle.com>,
	Huacai Chen <chenhuacai@...nel.org>,
	Yanteng Si <siyanteng@...ngson.cn>,
	linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org,
	coresight@...ts.linaro.org, linux-arm-kernel@...ts.infradead.org,
	bpf@...r.kernel.org, Leo Yan <leo.yan@...ux.dev>
Subject: Re: [PATCH v3 0/8] Clean up libperf cpumap's empty function

On Thu, Mar 07, 2024 at 03:47:00PM -0800, Namhyung Kim wrote:
> Hi Ian,
> 
> Sorry for the late reply.
> 
> On Fri, Feb 16, 2024 at 5:04 PM Namhyung Kim <namhyung@...nel.org> wrote:
> >
> > On Wed, Feb 14, 2024 at 2:03 PM Ian Rogers <irogers@...gle.com> wrote:
> > >
> > > On Fri, Feb 2, 2024 at 3:41 PM Ian Rogers <irogers@...gle.com> wrote:
> > > >
> > > > Rename and clean up the use of libperf CPU map functions particularly
> > > > focussing on perf_cpu_map__empty that may return true for maps
> > > > containing CPUs but also with an "any CPU"/dummy value.
> > > >
> > > > perf_cpu_map__nr is also troubling in that iterating an empty CPU map
> > > > will yield the "any CPU"/dummy value. Reduce the appearance of some
> > > > calls to this by using the perf_cpu_map__for_each_cpu macro.
> > > >
> > > > v3: Address handling of "any" is arm-spe/cs-etm patch.
> > > > v2: 6 patches were merged by Arnaldo. New patch added ensure empty
> > > >     maps are allocated as NULL (suggested by James Clark). Hopefully a
> > > >     fix to "perf arm-spe/cs-etm: Directly iterate CPU maps".
> > > >
> > > > Ian Rogers (8):
> > > >   libperf cpumap: Add any, empty and min helpers
> > > >   libperf cpumap: Ensure empty cpumap is NULL from alloc
> > > >   perf arm-spe/cs-etm: Directly iterate CPU maps
> > > >   perf intel-pt/intel-bts: Switch perf_cpu_map__has_any_cpu_or_is_empty
> > > >     use
> > > >   perf cpumap: Clean up use of perf_cpu_map__has_any_cpu_or_is_empty
> > > >   perf arm64 header: Remove unnecessary CPU map get and put
> > > >   perf stat: Remove duplicate cpus_map_matched function
> > > >   perf cpumap: Use perf_cpu_map__for_each_cpu when possible
> > >
> > > Ping. Thanks,
> > > Ian

> > Adrian and James, are you ok with this now?

> I think James is fine now and the Intel-pt part seems straight-forward
> so I'd like to merge this change.  Please tell me if you have any concerns.

Namhyung,

	I noticed this hasn't been merged and applies cleanly, so I'm
adding it to perf-tools-next, from your comment above can I take it as
an Acked-by or even Reviewed-by?

- Arnaldo