linux-kernel - Re: [PATCH] floppy: remove duplicated code, unlock_fdc() function has the same code "do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7ce0d4b7-2e4d-44a7-b268-3e2505e01abe@linux.com>
Date: Mon, 18 Mar 2024 12:34:24 +0400
From: Denis Efremov <efremov@...ux.com>
To: Yufeng Wang <wangyufeng@...inos.cn>, Jens Axboe <axboe@...nel.dk>,
 linux-block@...r.kernel.org, linux-kernel@...r.kernel.org
Cc: stable@...r.kernel.org
Subject: Re: [PATCH] floppy: remove duplicated code, unlock_fdc() function has
 the same code "do_floppy = NULL" inside.

Hello,

Please, add a small commit message to the patch. The commit title
is too long and can be reduced to something like "floppy: remove duplicated
code in redo_fd_request()". Rest can be added to the commit message.

On 3/18/24 10:07, Yufeng Wang wrote:
> Cc: stable@...r.kernel.org

We don't need to send this patch to stable. It's not a bugfix.

Please, send v2 with commit message and new title.
The change looks good to me.

> Signed-off-by: Yufeng Wang <wangyufeng@...inos.cn>
> ---
>  drivers/block/floppy.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/block/floppy.c b/drivers/block/floppy.c
> index 1b399ec8c07d..25c9d85667f1 100644
> --- a/drivers/block/floppy.c
> +++ b/drivers/block/floppy.c
> @@ -2787,7 +2787,6 @@ static void redo_fd_request(void)
>  		pending = set_next_request();
>  		spin_unlock_irq(&floppy_lock);
>  		if (!pending) {
> -			do_floppy = NULL;
>  			unlock_fdc();
>  			return;
>  		}

Thanks,
Denis