linux-kernel - Re: [PATCH 2/2] nvmem: Remove qoriq-efuse in favor of layerscape-sfp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6f5636e65df5616395cc8e24f63b09ef@bit42.se>
Date: Mon, 18 Mar 2024 09:32:35 +0100
From: richard@...42.se
To: Sean Anderson <sean.anderson@...ux.dev>
Cc: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
 linux-kernel@...r.kernel.org, Niklas Söderlund
 <niklas.soderlund@...natech.se>, Michael Walle <michael@...le.cc>, Greg
 Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH 2/2] nvmem: Remove qoriq-efuse in favor of layerscape-sfp

On 2024-03-16 01:20, Sean Anderson wrote:
> The qoriq-efuse driver is a duplicate of layerscape-sfp.c. The T-series
> uses TA 2.0, while Layerscape uses TA 2.1 or 3.0 (depending on the
> chip). Add appropriate compatibles to the layerscape-sfp driver and
> remove the qoriq-efuse driver. I did not add support for P-series SoCs,
> since they use TA 1.0 which doesn't share a major version with either 
> of
> the existing implementations.
> 
> The qoriq-efuse driver does not properly abstract the location/offset 
> of
> the fuses properly, instead exposing the device's whole address range 
> to
> userspace. This is not appropriate, as the fuses only occupy a small
> portion of this range. The layerscape-sfp module correctly constrains
> the nvmem size to the fuses size. This represents a (necessary)
> compatibility break. The qoriq-efuse driver has been in-tree for around
> six months. Hopefully this will limit the fallout.
> 
> I would appreciate if someone with access to trust architecture 2.0 
> user
> guide could confirm the number of fuses.
> 
> Fixes: 0861110bb421 ("nvmem: add new NXP QorIQ eFuse driver")
> Signed-off-by: Sean Anderson <sean.anderson@...ux.dev>
I don't think Fixes is appropriate here. Apart from that:

Acked-by: Richard Alpe <richard@...42.se>