linux-kernel - Re: [RFC PATCH 1/3] powerpc/pseries/iommu: Bring back userspace view for single level TCE tables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240319143202.GA66976@ziepe.ca>
Date: Tue, 19 Mar 2024 11:32:02 -0300
From: Jason Gunthorpe <jgg@...pe.ca>
To: Shivaprasad G Bhat <sbhat@...ux.ibm.com>
Cc: tpearson@...torengineering.com, alex.williamson@...hat.com,
	linuxppc-dev@...ts.ozlabs.org, mpe@...erman.id.au,
	npiggin@...il.com, christophe.leroy@...roup.eu,
	aneesh.kumar@...nel.org, naveen.n.rao@...ux.ibm.com,
	gbatra@...ux.vnet.ibm.com, brking@...ux.vnet.ibm.com, aik@...abs.ru,
	robh@...nel.org, linux-kernel@...r.kernel.org, kvm@...r.kernel.org,
	aik@....com, msuchanek@...e.de, jroedel@...e.de,
	vaibhav@...ux.ibm.com, svaidy@...ux.ibm.com
Subject: Re: [RFC PATCH 1/3] powerpc/pseries/iommu: Bring back userspace view
 for single level TCE tables

On Tue, Mar 12, 2024 at 01:14:20PM -0500, Shivaprasad G Bhat wrote:
> The commit 090bad39b237a ("powerpc/powernv: Add indirect levels to
> it_userspace") which implemented the tce indirect levels
> support for PowerNV ended up removing the single level support
> which existed by default(generic tce_iommu_userspace_view_alloc/free()
> calls). On pSeries the TCEs are single level, and the allocation
> of userspace view is lost with the removal of generic code.

:( :(

If this has been broken since 2018 and nobody cared till now can we
please go in a direction of moving this code to the new iommu APIs
instead of doubling down on more of this old stuff that apparently
almost nobody cares about ??

Jason