linux-kernel - Re: [RFC PATCH 1/3] powerpc/pseries/iommu: Bring back userspace view for single level TCE tables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 19 Mar 2024 13:36:51 -0500 (CDT)
From: Timothy Pearson <tpearson@...torengineering.com>
To: Jason Gunthorpe <jgg@...pe.ca>
Cc: Shivaprasad G Bhat <sbhat@...ux.ibm.com>, 
	Timothy Pearson <tpearson@...torengineering.com>, 
	Alex Williamson <alex.williamson@...hat.com>, 
	linuxppc-dev <linuxppc-dev@...ts.ozlabs.org>, 
	Michael Ellerman <mpe@...erman.id.au>, npiggin <npiggin@...il.com>, 
	christophe leroy <christophe.leroy@...roup.eu>, 
	aneesh kumar <aneesh.kumar@...nel.org>, 
	naveen n rao <naveen.n.rao@...ux.ibm.com>, 
	gbatra <gbatra@...ux.vnet.ibm.com>, brking@...ux.vnet.ibm.com, 
	Alexey Kardashevskiy <aik@...abs.ru>, robh@...nel.org, 
	linux-kernel <linux-kernel@...r.kernel.org>, 
	kvm <kvm@...r.kernel.org>, aik <aik@....com>, msuchanek@...e.de, 
	jroedel <jroedel@...e.de>, vaibhav <vaibhav@...ux.ibm.com>, 
	svaidy@...ux.ibm.com
Subject: Re: [RFC PATCH 1/3] powerpc/pseries/iommu: Bring back userspace
 view for single level TCE tables



----- Original Message -----
> From: "Jason Gunthorpe" <jgg@...pe.ca>
> To: "Shivaprasad G Bhat" <sbhat@...ux.ibm.com>
> Cc: "Timothy Pearson" <tpearson@...torengineering.com>, "Alex Williamson" <alex.williamson@...hat.com>, "linuxppc-dev"
> <linuxppc-dev@...ts.ozlabs.org>, "Michael Ellerman" <mpe@...erman.id.au>, "npiggin" <npiggin@...il.com>, "christophe
> leroy" <christophe.leroy@...roup.eu>, "aneesh kumar" <aneesh.kumar@...nel.org>, "naveen n rao"
> <naveen.n.rao@...ux.ibm.com>, "gbatra" <gbatra@...ux.vnet.ibm.com>, brking@...ux.vnet.ibm.com, "Alexey Kardashevskiy"
> <aik@...abs.ru>, robh@...nel.org, "linux-kernel" <linux-kernel@...r.kernel.org>, "kvm" <kvm@...r.kernel.org>, "aik"
> <aik@....com>, msuchanek@...e.de, "jroedel" <jroedel@...e.de>, "vaibhav" <vaibhav@...ux.ibm.com>, svaidy@...ux.ibm.com
> Sent: Tuesday, March 19, 2024 9:32:02 AM
> Subject: Re: [RFC PATCH 1/3] powerpc/pseries/iommu: Bring back userspace view for single level TCE tables

> On Tue, Mar 12, 2024 at 01:14:20PM -0500, Shivaprasad G Bhat wrote:
>> The commit 090bad39b237a ("powerpc/powernv: Add indirect levels to
>> it_userspace") which implemented the tce indirect levels
>> support for PowerNV ended up removing the single level support
>> which existed by default(generic tce_iommu_userspace_view_alloc/free()
>> calls). On pSeries the TCEs are single level, and the allocation
>> of userspace view is lost with the removal of generic code.
> 
> :( :(
> 
> If this has been broken since 2018 and nobody cared till now can we
> please go in a direction of moving this code to the new iommu APIs
> instead of doubling down on more of this old stuff that apparently
> almost nobody cares about ??
> 
> Jason

Just FYI Raptor is working on porting things over to the new APIs.  RFC patches should be posted in the next week or two.