[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <65f8de878e8e1_7702a294f4@dwillia2-xfh.jf.intel.com.notmuch>
Date: Mon, 18 Mar 2024 17:38:31 -0700
From: Dan Williams <dan.j.williams@...el.com>
To: Jonathan Cameron <Jonathan.Cameron@...wei.com>, Yuquan Wang
<wangyuquan1236@...tium.com.cn>
CC: <ira.weiny@...el.com>, <dan.j.williams@...el.com>,
<linux-cxl@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
<qemu-devel@...gnu.org>, <chenbaozi@...tium.com.cn>
Subject: Re: [PATCH v2 1/1] cxl/mem: Fix for the index of Clear Event Record
Handle
Jonathan Cameron wrote:
> On Mon, 18 Mar 2024 10:29:28 +0800
> Yuquan Wang <wangyuquan1236@...tium.com.cn> wrote:
>
> > The dev_dbg info for Clear Event Records mailbox command would report
> > the handle of the next record to clear not the current one.
> >
> > This was because the index 'i' had incremented before printing the
> > current handle value.
> >
> > Signed-off-by: Yuquan Wang <wangyuquan1236@...tium.com.cn>
> > ---
> > drivers/cxl/core/mbox.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/cxl/core/mbox.c b/drivers/cxl/core/mbox.c
> > index 9adda4795eb7..b810a6aa3010 100644
> > --- a/drivers/cxl/core/mbox.c
> > +++ b/drivers/cxl/core/mbox.c
> > @@ -915,7 +915,7 @@ static int cxl_clear_event_record(struct cxl_memdev_state *mds,
> >
> > payload->handles[i++] = gen->hdr.handle;
> > dev_dbg(mds->cxlds.dev, "Event log '%d': Clearing %u\n", log,
> > - le16_to_cpu(payload->handles[i]));
> > + le16_to_cpu(payload->handles[i-1]));
> Trivial but needs spaces around the -. e.g. [i - 1]
>
> Maybe Dan can fix up whilst applying.
>
> Otherwise
>
> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>
I have enlisted Dave to start wrangling CXL kernel patches upstream, and
I will fall back to just reviewing.
Dave, you can add my:
Reviewed-by: Dan Williams <dan.j.williams@...el.com>
..with the same caveat as above.
Powered by blists - more mailing lists