linux-kernel - Re: [PATCH v1] usb: typec: Return size of buffer if pd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 19 Mar 2024 06:58:29 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Kyle Tso <kyletso@...gle.com>, heikki.krogerus@...ux.intel.com,
 gregkh@...uxfoundation.org
Cc: badhri@...gle.com, linux-kernel@...r.kernel.org,
 linux-usb@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH v1] usb: typec: Return size of buffer if pd_set operation
 succeeds

On 3/19/24 00:43, Kyle Tso wrote:
> The attribute writing should return the number of bytes used from the
> buffer on success.
> 
> Fixes: a7cff92f0635 ("usb: typec: USB Power Delivery helpers for ports and partners")
> Cc: stable@...r.kernel.org
> Signed-off-by: Kyle Tso <kyletso@...gle.com>

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

> ---
>   drivers/usb/typec/class.c | 7 ++++++-
>   1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/typec/class.c b/drivers/usb/typec/class.c
> index 389c7f0b8d93..9610e647a8d4 100644
> --- a/drivers/usb/typec/class.c
> +++ b/drivers/usb/typec/class.c
> @@ -1310,6 +1310,7 @@ static ssize_t select_usb_power_delivery_store(struct device *dev,
>   {
>   	struct typec_port *port = to_typec_port(dev);
>   	struct usb_power_delivery *pd;
> +	int ret;
>   
>   	if (!port->ops || !port->ops->pd_set)
>   		return -EOPNOTSUPP;
> @@ -1318,7 +1319,11 @@ static ssize_t select_usb_power_delivery_store(struct device *dev,
>   	if (!pd)
>   		return -EINVAL;
>   
> -	return port->ops->pd_set(port, pd);
> +	ret = port->ops->pd_set(port, pd);
> +	if (ret)
> +		return ret;
> +
> +	return size;
>   }
>   
>   static ssize_t select_usb_power_delivery_show(struct device *dev,