linux-kernel - Re: [PATCH v2 1/1] platform/x86: asus-wmi: add support for Vivobook GPU MUX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Thu, 21 Mar 2024 09:07:41 +1300
From: "Luke Jones" <luke@...nes.dev>
To: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Cc: platform-driver-x86@...r.kernel.org,
 "Hans de Goede" <hdegoede@...hat.com>, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 1/1] platform/x86: asus-wmi: add support for Vivobook GPU MUX

On Thu, 21 Mar 2024, at 1:02 AM, Ilpo Järvinen wrote:
> On Wed, 20 Mar 2024, Luke Jones wrote:
> 
> > On Wed, 20 Mar 2024, at 1:26 AM, Ilpo Järvinen wrote:
> > > On Sun, 10 Mar 2024, Luke D. Jones wrote:
> > > 
> > > > Adjust existing MUX support to select whichever MUX support is available
> > > > so that ASUS Vivobook MUX can also be used if detected.
> > > 
> > > This description is a bit on the short side. It wouldn't have hurt to 
> > > first state that Vivobooks come with a GPU MUX WMI that has a different 
> > > WMI device ID. I can infer that after reading the diff but the description 
> > > should not require reading the patch.
> > 
> > Would you prefer I changed the commit message?
> 
> I kind of tried to give some leeway for you and not sound like I'm 
> enforcing you to do it but yes,

Hey it's not a problem at all. Part of the review and all feedback is valuable :)