linux-kernel - Re: [PATCH v2 1/1] platform/x86: asus-wmi: add support for Vivobook GPU MUX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 20 Mar 2024 14:02:27 +0200 (EET)
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: Luke Jones <luke@...nes.dev>
cc: platform-driver-x86@...r.kernel.org, Hans de Goede <hdegoede@...hat.com>, 
    LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 1/1] platform/x86: asus-wmi: add support for Vivobook
 GPU MUX

On Wed, 20 Mar 2024, Luke Jones wrote:

> On Wed, 20 Mar 2024, at 1:26 AM, Ilpo Järvinen wrote:
> > On Sun, 10 Mar 2024, Luke D. Jones wrote:
> > 
> > > Adjust existing MUX support to select whichever MUX support is available
> > > so that ASUS Vivobook MUX can also be used if detected.
> > 
> > This description is a bit on the short side. It wouldn't have hurt to 
> > first state that Vivobooks come with a GPU MUX WMI that has a different 
> > WMI device ID. I can infer that after reading the diff but the description 
> > should not require reading the patch.
> 
> Would you prefer I changed the commit message?

I kind of tried to give some leeway for you and not sound like I'm 
enforcing you to do it but yes, I do prefer good commit messages myself
(I know that after reading this patch the reasons will be pretty obvious 
to anyone so it's not a grave problem). So half it was said future 
patches in mind, half you can do it if you want also for this patch.

But since you'll need to resend this anyway because of the 
independent/series issue I mentioned in my reply to one of the other 
patches, just cover this minor thing as well, it's one sentence after
all.

-- 
 i.